Settings People Revamp: Implement Chrome Profile name/icon selection.

Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

4) Implements new functions necessary for manage_profile.html page in SyncPrivateApi.

5) Adds a manage_profile.html subpage that allows Chrome users to switch their name and icon.

BUG=563721
Committed: https://crrev.com/9cb23370b8d9d2f0bdaed145e5682ac862c424e1
Cr-Commit-Position: refs/heads/master@{#368181}

[tommycli, 2015-12-18 00:18:32]

Description was changed from

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

BUG=563721
==========

to

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the 
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

BUG=563721
==========

[tommycli, 2015-12-22 00:20:07]

Description was changed from

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the 
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

BUG=563721
==========

to

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the 
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

4) Implements new functions necessary for manage_profile.html page in
SyncPrivateApi.

5) Adds a manage_profile.html subpage that allows Chrome users to switch their
name and icon.

BUG=563721
==========

[tommycli, 2015-12-22 00:54:43]

tommycli@chromium.org changed reviewers:
+ dschuyler@chromium.org

[tommycli, 2015-12-22 00:54:43]

dschuyler: PTAL. This is a fat patch. It implements the Profile Icon and Name
selection within Settings.

[dschuyler, 2015-12-22 18:47:48]

I need to go over this CL again, but here's a first pass with some notes.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.html (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.html:16: <template
is="dom-repeat" items="{{availableIconUrls}}">
Can this be [[availableIconsUrls]] rather than using {{}}

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.html:18:
on-tap="onIconTap_" data-icon-url="{{item}}">
{{}} to [[]]

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.html:19: <img
src="{{item}}">
{{}} to [[]]

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:44: * Handler
for when the available icons are pushed from SyncPrivateApi.
@param

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:52: * Handler
for when the profile name field is changed, then blurred.
@param

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:61: * Handler
for when the user clicks a new profile icon.
@param

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:62: * @private
@return {boolean}

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:77: * Computed
binding determining which profile icon button is toggled on.
@param, @param

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:78: * @private
return type

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/people_page.html:89:
profile-name="{{profileName}}">
Do these require two way binding?

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/people_page.js:68: * Handler for
when the profile's icon and name is updated.
@param

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:788: const base::string16&
old_profile_name) {
comment out unused params

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:793: const base::FilePath&
profile_path) {
comment out unused param name.

[tommycli, 2015-12-22 21:58:33]

dschuyler: Thanks! see below

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.html (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.html:16: <template
is="dom-repeat" items="{{availableIconUrls}}">
On 2015/12/22 18:47:47, dschuyler wrote:
> Can this be [[availableIconsUrls]] rather than using {{}}

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.html:18:
on-tap="onIconTap_" data-icon-url="{{item}}">
On 2015/12/22 18:47:47, dschuyler wrote:
> {{}} to [[]]

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.html:19: <img
src="{{item}}">
On 2015/12/22 18:47:47, dschuyler wrote:
> {{}} to [[]]

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:44: * Handler
for when the available icons are pushed from SyncPrivateApi.
On 2015/12/22 18:47:48, dschuyler wrote:
> @param

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:52: * Handler
for when the profile name field is changed, then blurred.
On 2015/12/22 18:47:48, dschuyler wrote:
> @param

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:61: * Handler
for when the user clicks a new profile icon.
On 2015/12/22 18:47:48, dschuyler wrote:
> @param

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:62: * @private
On 2015/12/22 18:47:48, dschuyler wrote:
> @return {boolean}

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:77: * Computed
binding determining which profile icon button is toggled on.
On 2015/12/22 18:47:48, dschuyler wrote:
> @param, @param

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:78: * @private
On 2015/12/22 18:47:48, dschuyler wrote:
> return type

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/people_page.html:89:
profile-name="{{profileName}}">
On 2015/12/22 18:47:48, dschuyler wrote:
> Do these require two way binding?

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/people_page.js:68: * Handler for
when the profile's icon and name is updated.
On 2015/12/22 18:47:48, dschuyler wrote:
> @param

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:788: const base::string16&
old_profile_name) {
On 2015/12/22 18:47:48, dschuyler wrote:
> comment out unused params

Done.

https://codereview.chromium.org/1536593004/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:793: const base::FilePath&
profile_path) {
On 2015/12/22 18:47:48, dschuyler wrote:
> comment out unused param name.

Done.

[Dan Beam, 2015-12-28 23:28:56]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-12-28 23:28:57]

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:71:
element.dataset.iconUrl;
why if something else is tapped without a .dataset or .dataset.iconUrl?

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:77: return
false;
use event.preventDefault(); instead

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/sync_private_api.js (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/sync_private_api.js:119:
SyncPrivateApi.receiveProfileInfo = function(name, iconURL) {
nit: prefer iconUrl, as far as I know

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:231:
GetProfileInfoCache().RemoveObserver(this);
this should probably be above if (!web_ui()), yeah?

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:266: "GetProfileInfo",
these are typically casedLikeThis

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
(right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc:5: #include
"chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
why did this need a "Settings" in front?  it's in a different namespace, right? 
other compiler complications?

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.h (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.h:83: // The
associated profile.
might be worth mentioning weak ownership

[tommycli, 2016-01-04 21:40:13]

dbeam: thanks! see below

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:71:
element.dataset.iconUrl;
On 2015/12/28 23:28:57, Dan Beam wrote:
> why if something else is tapped without a .dataset or .dataset.iconUrl?

Done.

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:77: return
false;
On 2015/12/28 23:28:57, Dan Beam wrote:
> use event.preventDefault(); instead

Done.

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/sync_private_api.js (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/sync_private_api.js:119:
SyncPrivateApi.receiveProfileInfo = function(name, iconURL) {
On 2015/12/28 23:28:57, Dan Beam wrote:
> nit: prefer iconUrl, as far as I know

Done.

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:231:
GetProfileInfoCache().RemoveObserver(this);
On 2015/12/28 23:28:57, Dan Beam wrote:
> this should probably be above if (!web_ui()), yeah?

Done.

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler.cc:266: "GetProfileInfo",
On 2015/12/28 23:28:57, Dan Beam wrote:
> these are typically casedLikeThis

Done.

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
(right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc:5: #include
"chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
On 2015/12/28 23:28:57, Dan Beam wrote:
> why did this need a "Settings" in front?  it's in a different namespace,
right? 
> other compiler complications?

Yeah other compiler complications. Originally it was just manage_profile_handler

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.h (right):

https://codereview.chromium.org/1536593004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.h:83: // The
associated profile.
On 2015/12/28 23:28:57, Dan Beam wrote:
> might be worth mentioning weak ownership

Done.

[Dan Beam, 2016-01-04 22:06:11]

looks pretty good to me

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:66: * @return
{boolean}
remove @return

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:76: }
no curlies

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:83:
event.preventDefault();
only preventDefault if (iconUrl) exists (or conversely, bail early if
(!iconUrl))

[dschuyler, 2016-01-05 01:16:12]

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.h (right):

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.h:84: Profile*
profile_;
Can the ManageProfileHandler outlive the profile_?

[tommycli, 2016-01-05 01:23:51]

dschuyler: thanks!!

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_manage_profile_handler.h (right):

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_manage_profile_handler.h:84: Profile*
profile_;
On 2016/01/05 01:16:12, dschuyler wrote:
> Can the ManageProfileHandler outlive the profile_?

I don't think so. I think the Profile outlives the WebContents outlives the
WebUI outlives the ManageProfileHandler.

[dschuyler, 2016-01-05 01:53:37]

lgtm

[tommycli, 2016-01-05 22:13:46]

dbeam: ping, thanks!

[tommycli, 2016-01-06 20:30:05]

dbeam: oops missed a few comments from last go-around. Should be complete now.
Latest patchset also includes a rebase.

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:66: * @return
{boolean}
On 2016/01/04 22:06:11, Dan Beam wrote:
> remove @return

Done.

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:76: }
On 2016/01/04 22:06:11, Dan Beam wrote:
> no curlies

Done.

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:83:
event.preventDefault();
On 2016/01/04 22:06:11, Dan Beam wrote:
> only preventDefault if (iconUrl) exists (or conversely, bail early if
> (!iconUrl))

Done.

[Dan Beam, 2016-01-07 02:41:20]

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.css (right):

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.css:10: margin:
16px 0 0 16px;
RTL

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:76: if (iconUrl)
{
arguable nit:

if (!iconUrl)
  return;

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/people_page.js:57: profileName:
String,
can these be private?

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/sync_private_api.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/sync_private_api.js:260:
chrome.send('syncSetupManageOtherPeople');
arguably do in a separate patch

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/settings_page/settings_router.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/settings_page/settings_router.js:267:
window.history.pushState(historicState, document.title, route.url);
such a useless param...

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/people_handler_unittest.cc (left):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler_unittest.cc:195:
SigninManagerFactory::GetForProfile(profile_.get()));
arguably do all these separately

[tommycli, 2016-01-07 22:08:23]

dbeam: Address rest of comments here. Per offline discussion, sending to CQ.

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.css (right):

https://codereview.chromium.org/1536593004/diff/180001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.css:10: margin:
16px 0 0 16px;
On 2016/01/07 02:41:19, Dan Beam wrote:
> RTL

Done.

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/manage_profile.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/manage_profile.js:76: if (iconUrl)
{
On 2016/01/07 02:41:19, Dan Beam wrote:
> arguable nit:
> 
> if (!iconUrl)
>   return;

Done.

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/people_page.js:57: profileName:
String,
On 2016/01/07 02:41:20, Dan Beam wrote:
> can these be private?

Done.

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/people_page/sync_private_api.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/people_page/sync_private_api.js:260:
chrome.send('syncSetupManageOtherPeople');
On 2016/01/07 02:41:20, Dan Beam wrote:
> arguably do in a separate patch

Done.

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
File chrome/browser/resources/settings/settings_page/settings_router.js (right):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/resourc...
chrome/browser/resources/settings/settings_page/settings_router.js:267:
window.history.pushState(historicState, document.title, route.url);
On 2016/01/07 02:41:20, Dan Beam wrote:
> such a useless param...

Acknowledged.

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/people_handler_unittest.cc (left):

https://codereview.chromium.org/1536593004/diff/200001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/people_handler_unittest.cc:195:
SigninManagerFactory::GetForProfile(profile_.get()));
On 2016/01/07 02:41:20, Dan Beam wrote:
> arguably do all these separately

This must be in the same patch, as I need to change profile_ to a raw ptr.
(TestingProfileManager now owns it)

[tommycli, 2016-01-07 22:09:06]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-01-07 22:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1536593004/#ps240001
(title: " ")

[commit-bot: I haz the power, 2016-01-07 22:09:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536593004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536593004/240001

[commit-bot: I haz the power, 2016-01-07 22:56:14]

Description was changed from

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the 
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

4) Implements new functions necessary for manage_profile.html page in
SyncPrivateApi.

5) Adds a manage_profile.html subpage that allows Chrome users to switch their
name and icon.

BUG=563721
==========

to

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the 
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

4) Implements new functions necessary for manage_profile.html page in
SyncPrivateApi.

5) Adds a manage_profile.html subpage that allows Chrome users to switch their
name and icon.

BUG=563721
==========

[commit-bot: I haz the power, 2016-01-07 22:56:15]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-01-07 22:57:08]

Description was changed from

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the 
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

4) Implements new functions necessary for manage_profile.html page in
SyncPrivateApi.

5) Adds a manage_profile.html subpage that allows Chrome users to switch their
name and icon.

BUG=563721
==========

to

==========
Settings People Revamp: Implement Chrome Profile name/icon selection.

1) Decouple the profile icon and name updates from the
   SyncStatus struct. They are now updated separately.
   See SyncPrivateApi.getProfileInfo.

2) Updates PeopleHandler to send new profile icon and name
   updates in response to these changing.

3) Copies a subset of options::ManageProfileHandler to
   settings::ManageProfileHandler. The parts left behind are
   functionality that will be subsumed by the new native User Manager.

4) Implements new functions necessary for manage_profile.html page in
SyncPrivateApi.

5) Adds a manage_profile.html subpage that allows Chrome users to switch their
name and icon.

BUG=563721

Committed: https://crrev.com/9cb23370b8d9d2f0bdaed145e5682ac862c424e1
Cr-Commit-Position: refs/heads/master@{#368181}
==========

[commit-bot: I haz the power, 2016-01-07 22:57:08]

Patchset 13 (id:??) landed as
https://crrev.com/9cb23370b8d9d2f0bdaed145e5682ac862c424e1
Cr-Commit-Position: refs/heads/master@{#368181}

[Łukasz Anforowicz, 2016-01-07 23:18:05]

A revert of this CL (patchset #13 id:240001) has been created in
https://codereview.chromium.org/1568963003/ by lukasza@chromium.org.

The reason for reverting is: This is the main suspect for causing a build
failure below:

https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li....