Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
TBR=sky@chromium.org

Committed: https://crrev.com/49c08c85169c0caa29928db9f68ac9f734b08f3a
Cr-Commit-Position: refs/heads/master@{#371993}

[dzhioev (left Google), 2015-12-17 01:37:22]

Description was changed from

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
==========

to

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
==========

[dzhioev (left Google), 2015-12-17 01:37:22]

dzhioev@chromium.org changed reviewers:
+ xiyuan@chromium.org

[dzhioev (left Google), 2015-12-17 01:37:40]

Hi, PTAL

[dzhioev (left Google), 2015-12-17 01:57:00]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 02:36:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/20001

[commit-bot: I haz the power, 2015-12-17 03:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 03:37:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dzhioev (left Google), 2015-12-17 03:43:03]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 03:45:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/20001

[commit-bot: I haz the power, 2015-12-17 03:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 03:55:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xiyuan, 2015-12-17 06:06:12]

lgtm

[dzhioev (left Google), 2015-12-17 22:45:47]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 22:46:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/20001

[commit-bot: I haz the power, 2015-12-17 23:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 23:11:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dzhioev (left Google), 2015-12-22 01:55:10]

The CQ bit was checked by dzhioev@chromium.org

[dzhioev (left Google), 2015-12-22 01:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1536553002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-12-22 01:55:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/40001

[commit-bot: I haz the power, 2015-12-22 02:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 02:55:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dzhioev (left Google), 2016-01-21 06:00:20]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 06:00:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/60001

[commit-bot: I haz the power, 2016-01-21 07:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 07:00:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dzhioev (left Google), 2016-01-22 03:28:03]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 03:28:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/80001

[commit-bot: I haz the power, 2016-01-22 03:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 03:34:43]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[dzhioev (left Google), 2016-01-22 06:04:30]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 06:04:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/100001

[commit-bot: I haz the power, 2016-01-22 06:52:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 06:52:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dzhioev (left Google), 2016-01-25 23:45:27]

The CQ bit was checked by dzhioev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 23:48:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/120001

[commit-bot: I haz the power, 2016-01-26 00:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 00:40:28]

Dry run: This issue passed the CQ dry run.

[dzhioev (left Google), 2016-01-26 01:05:43]

Xiyuan, please take another look. Turned out WebUIWebViewBrowserTest-s are
launched inside chrome://chrome-signin Web UI. Since I disabled chrome-signin on
CrOS, the tests stopped to work. The only <webview>-enabled Web UI on CrOS is
chrome://oobe, so I changed tests to use this Web UI.

[xiyuan, 2016-01-26 16:39:57]

LGTM!

I forgot WebUIWebViewBrowserTests also run for ChromeOS. Thank you for taking
care of it.

https://codereview.chromium.org/1536553002/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):

https://codereview.chromium.org/1536553002/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/webui_webview_browsertest.cc:43: return
GURL("chrome://oobe/login");
nit: return GURL(chrome::kChromeUIOobeURL).Resolve("/login");

I even wanted to use OobeUI::kLoginDisplay for the "/login" part. But that would
need more #include and #ifdefs unrelated to the test here. So feels not worth
it.

[dzhioev (left Google), 2016-01-28 00:27:00]

https://codereview.chromium.org/1536553002/diff/120001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/webui_webview_browsertest.cc (right):

https://codereview.chromium.org/1536553002/diff/120001/chrome/browser/ui/webu...
chrome/browser/ui/webui/webui_webview_browsertest.cc:43: return
GURL("chrome://oobe/login");
On 2016/01/26 16:39:56, xiyuan wrote:
> nit: return GURL(chrome::kChromeUIOobeURL).Resolve("/login");
> 
> I even wanted to use OobeUI::kLoginDisplay for the "/login" part. But that
would
> need more #include and #ifdefs unrelated to the test here. So feels not worth
> it.

Done.

[dzhioev (left Google), 2016-01-28 00:27:05]

The CQ bit was checked by dzhioev@chromium.org

[dzhioev (left Google), 2016-01-28 00:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1536553002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-01-28 00:28:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/140001

[commit-bot: I haz the power, 2016-01-28 00:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 00:31:55]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dzhioev (left Google), 2016-01-28 00:50:58]

The CQ bit was checked by dzhioev@chromium.org

[dzhioev (left Google), 2016-01-28 00:50:58]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1536553002/#ps160001
(title: "Merge conflicts resolved.")

[commit-bot: I haz the power, 2016-01-28 00:53:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/160001

[commit-bot: I haz the power, 2016-01-28 01:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:06:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dzhioev (left Google), 2016-01-28 03:02:35]

Description was changed from

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
==========

to

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
TBR=sky@chromium.org
==========

[dzhioev (left Google), 2016-01-28 03:03:47]

Trivial changes in chrome/test/BUILD.gn and signin_view_controller.cc TBR by
sky@.

[dzhioev (left Google), 2016-01-28 03:03:57]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2016-01-28 03:07:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536553002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536553002/160001

[commit-bot: I haz the power, 2016-01-28 03:28:55]

Description was changed from

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
TBR=sky@chromium.org
==========

to

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-01-28 03:28:56]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-01-28 03:30:24]

Description was changed from

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
TBR=sky@chromium.org
==========

to

==========
Remove InlineLoginHandlerChromeOS and exclude InlineLoginUI from CrOS build.

BUG=546731
TBR=sky@chromium.org

Committed: https://crrev.com/49c08c85169c0caa29928db9f68ac9f734b08f3a
Cr-Commit-Position: refs/heads/master@{#371993}
==========

[commit-bot: I haz the power, 2016-01-28 03:30:26]

Patchset 9 (id:??) landed as
https://crrev.com/49c08c85169c0caa29928db9f68ac9f734b08f3a
Cr-Commit-Position: refs/heads/master@{#371993}