Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1536493002: Working proof of concept of select to speak (Closed)

Created:
5 years ago by dmazzoni
Modified:
4 years, 11 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, tdanderson+views_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, tdresser+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Working proof of concept of select to speak BUG=

Patch Set 1 #

Patch Set 2 : Impl web support, but scroll offsets are ignored #

Patch Set 3 : Rebase, fix coordinate system so it works in scrolled pages #

Patch Set 4 : Drag across multiple objects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -19 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.html View 1 chunk +2 lines, -7 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/s2s/background/background.js View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/s2s/background/loader.js View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AXObjectCache.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 1 chunk +30 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 1 chunk +25 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/events/event_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/event_handler.cc View 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 2 chunks +26 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 3 (1 generated)
dmazzoni
5 years ago (2015-12-16 23:44:18 UTC) #2
dmazzoni
5 years ago (2015-12-17 22:59:28 UTC) #3 
Now supports web too! Doesn't work correctly if the page is scrolled down
unfortunately, will look into that next.

Powered by Google App Engine
This is Rietveld 408576698