Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1536443002: Refactor and comment BreakingContext::handleText() - Part 2 (Closed)

Created:
5 years ago by rhogan
Modified:
4 years, 11 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor and comment BreakingContext::handleText() - Part 2 Continue the refactoring from https://codereview.chromium.org/1504083002 by moving most of the detail in this function to helper functions. This makes the behaviour of the function more explicit - namely a loop that skips over non-whitespace and/or collapsible whitespace but returns early if it encounters a soft or hard line-breaking opportunity. BUG=567080 Committed: https://crrev.com/0b36cf70d82e790bf6e1fe62a35b3705f702a2ed Cr-Commit-Position: refs/heads/master@{#367052}

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -88 lines) Patch
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 9 chunks +124 lines, -88 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
rhogan
5 years ago (2015-12-17 20:25:18 UTC) #3
rhogan
On 2015/12/17 at 20:25:18, rhogan wrote: >
4 years, 12 months ago (2015-12-23 17:27:52 UTC) #5
rhogan
On 2015/12/23 at 17:27:52, rhogan wrote: > On 2015/12/17 at 20:25:18, rhogan wrote: > > ...
4 years, 12 months ago (2015-12-23 17:28:21 UTC) #6
eae
Those function signatures makes my head hurt but it is a step in the right ...
4 years, 11 months ago (2015-12-28 17:35:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536443002/40001
4 years, 11 months ago (2015-12-29 04:02:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-29 04:42:34 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 04:43:35 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b36cf70d82e790bf6e1fe62a35b3705f702a2ed
Cr-Commit-Position: refs/heads/master@{#367052}

Powered by Google App Engine
This is Rietveld 408576698