Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 153643006: sync: Remove dead code related to ClearUserData (Closed)

Created:
6 years, 10 months ago by rlarocque
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

sync: Remove dead code related to ClearUserData Removes some code left over from the ClearUserData feature. These are mostly functions named 'OnStopSyncingPermanently'. Also renames ProfileSyncService::OnStopSyncingPermanently to StopSyncingPermanently. This makes it easier to distinguish from the now deprecated SyncManagerObserver callback. The new name is more appropriate name since this function is not really a callback or event handler anymore. BUG=342932 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -61 lines) Patch
M chrome/browser/sync/glue/sync_backend_host_core.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync_driver/sync_frontend.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/debug_info_event_listener.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rlarocque
Please review.
6 years, 10 months ago (2014-02-11 22:37:03 UTC) #1
rlarocque
+Roger for sync_setup_handler.cc OWNERs review.
6 years, 10 months ago (2014-02-11 22:38:03 UTC) #2
tim (not reviewing)
lgtm
6 years, 10 months ago (2014-02-11 23:00:24 UTC) #3
Roger Tawa OOO till Jul 10th
sync_setup_handler.cc lgtm
6 years, 10 months ago (2014-02-12 14:48:31 UTC) #4
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 10 months ago (2014-02-12 17:12:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/153643006/1
6 years, 10 months ago (2014-02-12 17:12:13 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 19:25:26 UTC) #7
Message was sent while issue was closed.
Change committed as 250775

Powered by Google App Engine
This is Rietveld 408576698