Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1536423003: gn: Pass pkg_config_args when invoking pkg_config_script. (Closed)

Created:
5 years ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Pass pkg_config_args when invoking pkg_config_script. When invoking pkg_config_script directly, it is important to pass |pkg_config_args| together with the other arguments wanted, otherwise parameters such as --sysroot will not be passed to the pkg-config.py wrapper. In practice, this means that the libraries in the sysroots will not be used and the dependencies will be unconditionally looked for in the host system. R=sbc@chromium.org,dtseng@chromium.org,dmazzoni@chromium.org,dpranke@chromium.org Committed: https://crrev.com/403ef7949f66bc95994276fa153a4e8e6464e68b Cr-Commit-Position: refs/heads/master@{#369204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Raphael Kubo da Costa (rakuco)
+sbc for the patch as a whole. +dpranke for build/config +dmazzoni,dtseng for ui/accessibility.
5 years ago (2015-12-21 17:53:11 UTC) #1
Dirk Pranke
lgtm
5 years ago (2015-12-23 04:06:30 UTC) #2
Raphael Kubo da Costa (rakuco)
ping ui/ guys
4 years, 11 months ago (2016-01-06 13:00:01 UTC) #3
Sam Clegg
lgtm (not an OWNER)
4 years, 11 months ago (2016-01-06 16:39:42 UTC) #4
Sam Clegg
Sorry, that ping was for dmazzoni@.
4 years, 11 months ago (2016-01-11 23:34:13 UTC) #5
dmazzoni
lgtm
4 years, 11 months ago (2016-01-13 17:05:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536423003/1
4 years, 11 months ago (2016-01-13 17:06:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 17:38:16 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/403ef7949f66bc95994276fa153a4e8e6464e68b Cr-Commit-Position: refs/heads/master@{#369204}
4 years, 11 months ago (2016-01-13 17:39:58 UTC) #11
Dirk Pranke
4 years, 11 months ago (2016-01-26 02:06:08 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698