Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1536323003: Revert of android: Remove custom browser compositor scheduling logic (Closed)

Created:
5 years ago by gone
Modified:
5 years ago
Reviewers:
brianderson, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam, mithro-old
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Remove custom browser compositor scheduling logic (patchset #6 id:100001 of https://codereview.chromium.org/1513933003/ ) Reason for revert: Speculatively reverting CL to try and fix observer flakiness. https://crbug.com/571030 Apologies if I'm off base! Original issue's description: > android: Remove custom browser compositor scheduling logic > > Use cc scheduler instead without a deadline. > This is mostly obsolete now that Surfaces allow independent updates > between renderer and browser. > > BUG=455894 > > Committed: https://crrev.com/7f045e4f2e9f7142c79e2eeb30b70716a1ea8f0b > Cr-Commit-Position: refs/heads/master@{#365861} TBR=brianderson@chromium.org,sievers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455894 Committed: https://crrev.com/1b0f7d5ea39348411bdd0997dde85eecc7fdb19f Cr-Commit-Position: refs/heads/master@{#366437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -60 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 6 chunks +58 lines, -4 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 13 chunks +204 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gone
Created Revert of android: Remove custom browser compositor scheduling logic
5 years ago (2015-12-21 19:15:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536323003/1
5 years ago (2015-12-21 19:15:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 19:16:48 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-21 19:17:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b0f7d5ea39348411bdd0997dde85eecc7fdb19f
Cr-Commit-Position: refs/heads/master@{#366437}

Powered by Google App Engine
This is Rietveld 408576698