Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 1536233004: Disable local_server_unittest on win only (Closed)

Created:
5 years ago by nednguyen
Modified:
5 years ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable local_server_unittest on win only The flaky dashboard shows that the test were failing only on win (https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiB0ZWxlbWV0cnlfdW5pdHRlc3RzICh3aXRoIHBhdGNoKQw) BUG=570955 Committed: https://crrev.com/9575f9a4af9115c88bf8ba04e63a77e14e1d2750 Cr-Commit-Position: refs/heads/master@{#366427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/local_server_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
5 years ago (2015-12-21 17:35:23 UTC) #3
sullivan
lgtm
5 years ago (2015-12-21 18:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536233004/1
5 years ago (2015-12-21 18:16:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 18:45:39 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9575f9a4af9115c88bf8ba04e63a77e14e1d2750 Cr-Commit-Position: refs/heads/master@{#366427}
5 years ago (2015-12-21 18:46:26 UTC) #10
nednguyen
4 years, 12 months ago (2015-12-25 20:31:26 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1544263002/ by nednguyen@google.com.

The reason for reverting is: May cause flakes to reappear..

Powered by Google App Engine
This is Rietveld 408576698