Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 153623010: A64: Disable inlining of functions that have a different context (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Disable inlining of functions that have a different context On A64, the register allocator doesn't have control of cp, so we can't arbitrarily switch the context BUG=none R=rodolph.perfetta@gmail.com, ulan@chromium.org, rodolph.perfetta@arm.com LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/hydrogen.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-06 13:05:04 UTC) #1
ulan
LGTM. Could you add a TODO there to remove it once cp is allocatable?
6 years, 10 months ago (2014-02-06 13:10:20 UTC) #2
jochen (gone - plz use gerrit)
updated CL description
6 years, 10 months ago (2014-02-06 13:21:17 UTC) #3
Rodolph Perfetta
lgtm
6 years, 10 months ago (2014-02-06 13:22:45 UTC) #4
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-06 13:26:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r19157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698