Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/debug-agent.h

Issue 153623009: Fixed space leak in DebuggerAgentSession. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/debug-agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 }; 76 };
77 77
78 78
79 // Debugger agent session. The session receives requests from the remote 79 // Debugger agent session. The session receives requests from the remote
80 // debugger and sends debugger events/responses to the remote debugger. 80 // debugger and sends debugger events/responses to the remote debugger.
81 class DebuggerAgentSession: public Thread { 81 class DebuggerAgentSession: public Thread {
82 public: 82 public:
83 DebuggerAgentSession(DebuggerAgent* agent, Socket* client) 83 DebuggerAgentSession(DebuggerAgent* agent, Socket* client)
84 : Thread("v8:DbgAgntSessn"), 84 : Thread("v8:DbgAgntSessn"),
85 agent_(agent), client_(client) {} 85 agent_(agent), client_(client) {}
86 ~DebuggerAgentSession();
86 87
87 void DebuggerMessage(Vector<uint16_t> message); 88 void DebuggerMessage(Vector<uint16_t> message);
88 void Shutdown(); 89 void Shutdown();
89 90
90 private: 91 private:
91 void Run(); 92 void Run();
92 93
93 void DebuggerMessage(Vector<char> message); 94 void DebuggerMessage(Vector<char> message);
94 95
95 DebuggerAgent* agent_; 96 DebuggerAgent* agent_;
(...skipping 13 matching lines...) Expand all
109 static bool SendMessage(Socket* conn, const Vector<uint16_t> message); 110 static bool SendMessage(Socket* conn, const Vector<uint16_t> message);
110 static bool SendMessage(Socket* conn, const v8::Handle<v8::String> message); 111 static bool SendMessage(Socket* conn, const v8::Handle<v8::String> message);
111 static int ReceiveAll(Socket* conn, char* data, int len); 112 static int ReceiveAll(Socket* conn, char* data, int len);
112 }; 113 };
113 114
114 } } // namespace v8::internal 115 } } // namespace v8::internal
115 116
116 #endif // ENABLE_DEBUGGER_SUPPORT 117 #endif // ENABLE_DEBUGGER_SUPPORT
117 118
118 #endif // V8_DEBUG_AGENT_H_ 119 #endif // V8_DEBUG_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug-agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698