Issue 153623009: Fixed space leak in DebuggerAgentSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153623009: Fixed space leak in DebuggerAgentSession. (Closed)

Created:
6 years, 10 months ago by Sven Panne

Modified:
6 years, 10 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixed space leak in DebuggerAgentSession. Ownership in this part is still very convoluted and should probably be cleaned up, this is only the minimal CL needed to fix the leak. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19148

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/debug-agent.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/debug-agent.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2014/02/06 12:02:55, Sven Panne wrote: I agree. This part of (ancient) code could be ...

6 years, 10 months ago (2014-02-06 12:05:41 UTC) #2

Sven Panne

6 years, 10 months ago (2014-02-06 12:09:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19148 (presubmit successful).