Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153623003: Avoid conditional check for resource_collection_ in RenderWidgetHostViewAura::SendReturnedDelegated… (Closed)

Created:
6 years, 10 months ago by vivekg_samsung
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid conditional check for resource_collection_ in RenderWidgetHostViewAura::SendReturnedDelegatedResources. The function RenderWidgetHostViewAura::SendReturnedDelegatedResources() is called only when there is a valid resource_collection_ object. This seems a redundant check as the call site already checks for it hence replacing the condition with a DCHECK(resource_collection_). R=danakj, sievers, aelias Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248949

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (0 generated)
vivekg
PTAL, thanks!
6 years, 10 months ago (2014-02-04 08:53:17 UTC) #1
danakj
LGTM https://codereview.chromium.org/153623003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/153623003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1544 content/browser/renderer_host/render_widget_host_view_aura.cc:1544: DCHECK(resource_collection_); Oh you already did this :) Awesome.
6 years, 10 months ago (2014-02-04 18:15:31 UTC) #2
vivekg_samsung
The CQ bit was checked by vivek.vg@samsung.com
6 years, 10 months ago (2014-02-04 20:20:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/153623003/1
6 years, 10 months ago (2014-02-04 20:27:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48026
6 years, 10 months ago (2014-02-04 21:14:42 UTC) #5
danakj
+piman OWNERS
6 years, 10 months ago (2014-02-04 21:23:45 UTC) #6
piman
lgtm
6 years, 10 months ago (2014-02-04 21:42:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/153623003/1
6 years, 10 months ago (2014-02-04 22:33:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/153623003/1
6 years, 10 months ago (2014-02-05 01:13:08 UTC) #9
vivekg
The CQ bit was unchecked by vivekg@chromium.org
6 years, 10 months ago (2014-02-05 06:33:14 UTC) #10
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 10 months ago (2014-02-05 06:34:00 UTC) #11
vivekg
The CQ bit was unchecked by vivekg@chromium.org
6 years, 10 months ago (2014-02-05 09:00:26 UTC) #12
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 10 months ago (2014-02-05 09:21:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/153623003/1
6 years, 10 months ago (2014-02-05 09:27:12 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 10:14:45 UTC) #15
Message was sent while issue was closed. 
Change committed as 248949

Powered by Google App Engine
This is Rietveld 408576698