Make ChromeOS shelf use Browser app name to group hosted app windows.

Make ChromeOS shelf use Browser app name to group hosted app windows.

The ChromeOS shelf currently uses the oldest navigation entry's URL to
find the extension to group with on the shelf. This can cause a single
browser window to associate with no launcher item, rendering the
browser window inaccessible. It's also possible to have a changing
launcher item because navigation entries get pruned.

This CL uses the browser's app name to determine the extension for a
hosted app window.

It also causes app tabs to group with a bookmark app if no extension
has a matching extent.

BUG=340590
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251995

[Mr4D (OOO till 08-26), 2014-02-07 17:44:03]

Sorry for the delay, but you have sent the CL to my corp account and not the
chromium account (changed that).

Please have a look!

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
(right):

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc:303:
refocus_pattern.MatchesURL(web_contents->GetURL())) ||
You cannot remove the line 299&300 since this matching is also performed on tabs
(which are no apps per definition - but they might match). So you should or that
in - or - create two separate cases for apps and tabs.

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc (right):

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc:59: return NULL;
Same here. A tab might still be an "app".

[calamity, 2014-02-17 02:03:17]

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
(right):

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc:303:
refocus_pattern.MatchesURL(web_contents->GetURL())) ||
On 2014/02/07 17:44:03, Mr4D wrote:
> You cannot remove the line 299&300 since this matching is also performed on
tabs
> (which are no apps per definition - but they might match). So you should or
that
> in - or - create two separate cases for apps and tabs.

Done.

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc (right):

https://codereview.chromium.org/153623002/diff/120001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc:59: return NULL;
On 2014/02/07 17:44:03, Mr4D wrote:
> Same here. A tab might still be an "app".

I just moved the app tab stuff up to line 43.

[Mr4D (OOO till 08-26), 2014-02-18 15:16:21]

lgtm

[calamity, 2014-02-19 03:23:16]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-02-19 03:24:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/153623002/190001

[commit-bot: I haz the power, 2014-02-19 08:19:24]

Change committed as 251995