Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1536213002:
[Extension UI] Observing WebContentsObserver from extension_settings_handler.cc (Closed)
|
Created:
5 years ago by limasdf Modified:
5 years ago Reviewers:
Devlin CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Extension UI] Observing WebContentsObserver from extension_settings_handler.cc
ExtensionSettingsHandler still inherit content::WebContentsObserver.
but starting observing code is removed by mistake.
this caused unpacked extension is not reloaded when pressing CTRL+R
BUG=526945
TEST=manual (CTRL+R on chrome://extensions reload unpacked extension)
Committed: https://crrev.com/6c57ed900648bf699491cb8d2bb90f82f703ec20
Cr-Commit-Position: refs/heads/master@{#366722}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 ========== to ========== Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 ==========
limasdf@gmail.com changed reviewers: + rdevlin.cronin@chromium.org
starting observing code is removed from https://codereview.chromium.org/1146693004/diff/20001/chrome/browser/ui/webui... I think you have a lot of work, so I took this issue without discussion. please understand.
Description was changed from ========== Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 ========== to ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 ==========
lgtm, thanks for taking this. :) Writing tests for the extension settings page is a pain, and doing so for reload is probably not worth it - but I assume you've tested locally?
Description was changed from ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 ========== to ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 TEST=manual (CTRL+R on chrome://extensions reload unpacked extension) ==========
Ooops, you're alive on weekend :) > But I assume you've tested locally? Sure! I always test manually and locally first. This CL is very straightforward. so I didn't added an unittest. But I honestly feel pain. let me add test. please wait.
On 2015/12/20 16:04:20, limasdf wrote: > Ooops, you're alive on weekend :) > > > But I assume you've tested locally? > Sure! I always test manually and locally first. > This CL is very straightforward. so I didn't added an unittest. > > But I honestly feel pain. let me add test. please wait. I mean pushing patch without test is pain :)
On 2015/12/20 16:04:20, limasdf wrote: > Ooops, you're alive on weekend :) > > > But I assume you've tested locally? > Sure! I always test manually and locally first. > This CL is very straightforward. so I didn't added an unittest. > > But I honestly feel pain. let me add test. please wait. If you can find a way to add one, it'd be great. But if it turns out to be too much hassle, really, don't worry about it. :)
commit first. because this is regression issue. people 're waiting for to be fixed.
The CQ bit was checked by limasdf@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536213002/1
Message was sent while issue was closed.
Description was changed from ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 TEST=manual (CTRL+R on chrome://extensions reload unpacked extension) ========== to ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 TEST=manual (CTRL+R on chrome://extensions reload unpacked extension) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 TEST=manual (CTRL+R on chrome://extensions reload unpacked extension) ========== to ========== [Extension UI] Observing WebContentsObserver from extension_settings_handler.cc ExtensionSettingsHandler still inherit content::WebContentsObserver. but starting observing code is removed by mistake. this caused unpacked extension is not reloaded when pressing CTRL+R BUG=526945 TEST=manual (CTRL+R on chrome://extensions reload unpacked extension) Committed: https://crrev.com/6c57ed900648bf699491cb8d2bb90f82f703ec20 Cr-Commit-Position: refs/heads/master@{#366722} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6c57ed900648bf699491cb8d2bb90f82f703ec20 Cr-Commit-Position: refs/heads/master@{#366722}
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
