Make it possible to symlink to dartdoc and pub in the SDK.

Make it possible to symlink to dartdoc and pub in the SDK.

BUG=9409

[dgrove, 2013-05-30 19:46:38]

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc#newcode7
sdk/bin/dartdoc:7: # dart-sdk/bin and/or dart-sdk/bin/pub has been symlinked to.
On MacOS, readlink
pub => dartdoc

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc#newcode13
sdk/bin/dartdoc:13: BIN_DIR="$(cd "${linked_path%/*}" ; pwd -P)"
I am not following what you're trying to do here. can you explain?

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc#newcode15
sdk/bin/dartdoc:15: DART_SDK="$(cd "${BIN_DIR%/*}" ; pwd -P)"
what is this used for?

https://codereview.chromium.org/15362003/diff/1/sdk/bin/pub
File sdk/bin/pub (right):

https://codereview.chromium.org/15362003/diff/1/sdk/bin/pub#newcode12
sdk/bin/pub:12: BIN_DIR="$(cd "${linked_path%/*}" ; pwd -P)"
ditto - I don't understand what this is trying to do.

[Bob Nystrom, 2013-05-30 20:00:34]

I just checked in a patch to the pub shell script. You'll want to merge that
into this, I think.

[nweiz, 2013-05-30 20:01:25]

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc
File sdk/bin/dartdoc (right):

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc#newcode7
sdk/bin/dartdoc:7: # dart-sdk/bin and/or dart-sdk/bin/pub has been symlinked to.
On MacOS, readlink
On 2013/05/30 19:46:38, dgrove wrote:
> pub => dartdoc

Done.

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc#newcode13
sdk/bin/dartdoc:13: BIN_DIR="$(cd "${linked_path%/*}" ; pwd -P)"
On 2013/05/30 19:46:38, dgrove wrote:
> I am not following what you're trying to do here. can you explain?

If dart-sdk/bin/dartdoc is symlinked to, $0 will point to the symlink, rather
than the resolved path, so we use readlink to resolve the symlink and get the
actual path.

https://codereview.chromium.org/15362003/diff/1/sdk/bin/dartdoc#newcode15
sdk/bin/dartdoc:15: DART_SDK="$(cd "${BIN_DIR%/*}" ; pwd -P)"
On 2013/05/30 19:46:38, dgrove wrote:
> what is this used for?

Left over from the pub script; removed.

[nweiz, 2013-05-30 20:50:45]

On 2013/05/30 20:00:34, Bob Nystrom wrote:
> I just checked in a patch to the pub shell script. You'll want to merge that
> into this, I think.

When merging with Bob's changes, I realized follow_links was broken in all
scripts that used it. I've expanded the scope of this CL to fix follow_links in
all scripts. It now correctly resolves all symlinks in a path, so all scripts
should work if they or their parent directory are symlinked.

[Bob Nystrom, 2013-05-30 21:04:07]

LGTM with the caveat that I'm a bash noob.

[ahe, 2013-05-31 08:03:37]

We have an external contributor working on something similar, see:
https://codereview.chromium.org/15954011/

As far as I can tell, Nathan's solution handles the case when there is a symlink
link to the bin directory.  However, it is rather difficult to make sure we're
not regressing, so yarkot1 is going to write some shell unit tests.

[nweiz, 2013-05-31 18:45:07]

On 2013/05/31 08:03:37, ahe wrote:
> We have an external contributor working on something similar, see:
> https://codereview.chromium.org/15954011/
> 
> As far as I can tell, Nathan's solution handles the case when there is a
symlink
> link to the bin directory.  However, it is rather difficult to make sure we're
> not regressing, so yarkot1 is going to write some shell unit tests.

It looks like Yarko's patch does everything this one does, so I'll let him do
it.

When he's finished, could someone close out issue 9409?