Issue 153613002: Deprecate the HTMLSourceElement.media IDL attribute

Issue 153613002: Deprecate the HTMLSourceElement.media IDL attribute (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, philipj_slow, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Deprecate the HTMLSourceElement.media IDL attribute Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/L5h6KP5nmbE/CGlSWugrFl0J BUG=338197 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166421

Patch Set 3 : indent #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/media/source-media-deprecated.html	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	LayoutTests/media/source-media-deprecated-expected.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLSourceElement.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Requesting review from Aaron and pre-rubberstamping IDL change from Jochen, to minimize timezone pains.

6 years, 10 months ago (2014-02-04 09:35:31 UTC) #2

acolwell GONE FROM CHROMIUM

lgtm https://codereview.chromium.org/153613002/diff/40001/LayoutTests/media/source-media-deprecated.html File LayoutTests/media/source-media-deprecated.html (right): https://codereview.chromium.org/153613002/diff/40001/LayoutTests/media/source-media-deprecated.html#newcode4 LayoutTests/media/source-media-deprecated.html:4: description("Test that HTMLSourceElement.media is deprecated"); nit: 4 space ...

6 years, 10 months ago (2014-02-04 15:36:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/153613002/140001

6 years, 10 months ago (2014-02-04 15:51:06 UTC) #6

Message was sent while issue was closed.

Change committed as 166421

Expand Messages | Collapse Messages