Fix a memory leak in CPDF_DataAvail::CheckHintTables

Fix a memory leak in CPDF_DataAvail::CheckHintTables

R=thestig@chromium.org, dml@google.com
BUG=pdfium:327
Committed: https://pdfium.googlesource.com/pdfium/+/6287ebc38e5aafc256b6248caae710ea09d0ede4

[Oliver Chang, 2015-12-18 21:31:25]

Lei, PTAL. Simple patch.

[Oliver Chang, 2015-12-18 21:33:27]

Patchset #2 (id:20001) has been deleted

[Oliver Chang, 2015-12-18 21:45:30]

oops, made a mistake. please see ps#2

[Lei Zhang, 2015-12-18 22:09:12]

https://codereview.chromium.org/1536113002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1536113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3605: 
What do you think of this?

nonstd::unique_ptr<CPDF_Object, ReleaseDeleter<CPDF_Object>> pHintStream(
    ParseIndirectObjectAt(szHSStart, 0));
CPDF_Stream* pStream = ToStream(pHintStream.get());
if (pStream && pHintTables->LoadHintStream(pStream))
  m_pHintTables = nonstd::move(pHintTables);

[Oliver Chang, 2015-12-18 22:18:30]

https://codereview.chromium.org/1536113002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1536113002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3605: 
On 2015/12/18 22:09:12, Lei Zhang wrote:
> What do you think of this?
> 
> nonstd::unique_ptr<CPDF_Object, ReleaseDeleter<CPDF_Object>> pHintStream(
>     ParseIndirectObjectAt(szHSStart, 0));
> CPDF_Stream* pStream = ToStream(pHintStream.get());
> if (pStream && pHintTables->LoadHintStream(pStream))
>   m_pHintTables = nonstd::move(pHintTables);

Thanks for the suggestion. I've simplified this a bit further. Please see latest
patch.

[Oliver Chang, 2015-12-18 22:19:07]

On 2015/12/18 22:18:30, Oliver Chang wrote:
>
https://codereview.chromium.org/1536113002/diff/40001/core/src/fpdfapi/fpdf_p...
> File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):
> 
>
https://codereview.chromium.org/1536113002/diff/40001/core/src/fpdfapi/fpdf_p...
> core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3605: 
> On 2015/12/18 22:09:12, Lei Zhang wrote:
> > What do you think of this?
> > 
> > nonstd::unique_ptr<CPDF_Object, ReleaseDeleter<CPDF_Object>> pHintStream(
> >     ParseIndirectObjectAt(szHSStart, 0));
> > CPDF_Stream* pStream = ToStream(pHintStream.get());
> > if (pStream && pHintTables->LoadHintStream(pStream))
> >   m_pHintTables = nonstd::move(pHintTables);
> 
> Thanks for the suggestion. I've simplified this a bit further. Please see
latest
> patch.

wait never mind, I'm stupid.

[Oliver Chang, 2015-12-18 22:21:54]

Please see latest patch.

[Lei Zhang, 2015-12-18 22:25:00]

lgtm

Hey, that last patch set looks really good! ;)

[Oliver Chang, 2015-12-18 22:27:53]

On 2015/12/18 22:25:00, Lei Zhang wrote:
> lgtm
> 
> Hey, that last patch set looks really good! ;)

:P

[Oliver Chang, 2015-12-18 22:28:01]

Description was changed from

==========
Fix a memory leak in CPDF_DataAvail::CheckHintTables

R=thestig@chromium.org,dml@google.com
BUG=pdfium:327
==========

to

==========
Fix a memory leak in CPDF_DataAvail::CheckHintTables

R=thestig@chromium.org, dml@google.com
BUG=pdfium:327

Committed:
https://pdfium.googlesource.com/pdfium/+/6287ebc38e5aafc256b6248caae710ea09d0...
==========

[Oliver Chang, 2015-12-18 22:28:02]

Committed patchset #5 (id:100001) manually as
6287ebc38e5aafc256b6248caae710ea09d0ede4 (presubmit successful).