Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1536083003: Remove update_client dependency on base/ui (Closed)

Created:
5 years ago by Sorin Jianu
Modified:
4 years, 12 months ago
Reviewers:
waffles
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove update_client dependency on base/ui BUG=571104 Committed: https://crrev.com/6ceef3eb0161e37f373afcc79c424d081f52434d Cr-Commit-Position: refs/heads/master@{#366998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/update_client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/update_client/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/update_client/background_downloader_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1409363008 Patch 1

Messages

Total messages: 8 (3 generated)
Sorin Jianu
5 years ago (2015-12-21 18:46:46 UTC) #2
waffles
lgtm
4 years, 12 months ago (2015-12-28 17:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536083003/1
4 years, 12 months ago (2015-12-28 18:25:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 19:22:43 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 19:24:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ceef3eb0161e37f373afcc79c424d081f52434d
Cr-Commit-Position: refs/heads/master@{#366998}

Powered by Google App Engine
This is Rietveld 408576698