Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1536073002: remove old completion API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
index 2289a925a565f4a76a7af80fb835dbf6ae1f1a2f..cb9d813e72c863726269675ca33d081f3f4a750c 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
@@ -88,17 +88,15 @@ class DartCompletionManager implements CompletionContributor {
/**
* The information about a requested list of completions within a Dart file.
*/
-class DartCompletionRequestImpl extends CompletionRequestImpl
- implements DartCompletionRequest {
- /**
- * The [LibraryElement] representing dart:core
- */
- LibraryElement _coreLib;
+class DartCompletionRequestImpl implements DartCompletionRequest {
+ @override
+ final AnalysisContext context;
- /**
- * The [DartType] for Object in dart:core
- */
- InterfaceType _objectType;
+ @override
+ final Source source;
+
+ @override
+ final int offset;
@override
Expression dotTarget;
@@ -106,20 +104,35 @@ class DartCompletionRequestImpl extends CompletionRequestImpl
@override
Source librarySource;
- OpType _opType;
+ @override
+ final ResourceProvider resourceProvider;
+
+ @override
+ final SearchEngine searchEngine;
@override
CompletionTarget target;
+ /**
+ * The [LibraryElement] representing dart:core
+ */
+ LibraryElement _coreLib;
+
+ /**
+ * The [DartType] for Object in dart:core
+ */
+ InterfaceType _objectType;
+
+ OpType _opType;
+
DartCompletionRequestImpl._(
- AnalysisContext context,
- ResourceProvider resourceProvider,
- SearchEngine searchEngine,
+ this.context,
+ this.resourceProvider,
+ this.searchEngine,
this.librarySource,
- Source source,
- int offset,
- CompilationUnit unit)
- : super(context, resourceProvider, searchEngine, source, offset) {
+ this.source,
+ this.offset,
+ CompilationUnit unit) {
_updateTargets(unit);
}

Powered by Google App Engine
This is Rietveld 408576698