Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2067)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_core.dart

Issue 1536073002: remove old completion API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/completion_core.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_core.dart b/pkg/analysis_server/lib/src/services/completion/completion_core.dart
index 7048a6e99891650a582d61ae82a8bb11cf750756..3dce012eb5e002bcb906f2d1ee85e49977c729b2 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_core.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_core.dart
@@ -25,9 +25,9 @@ class CompletionRequestImpl implements CompletionRequest {
/**
* The offset of the start of the text to be replaced.
- * This will be different than the offset used to request the completion
+ * This will be different than the [offset] used to request the completion
* suggestions if there was a portion of an identifier before the original
- * offset. In particular, the replacementOffset will be the offset of the
+ * [offset]. In particular, the [replacementOffset] will be the offset of the
* beginning of said identifier.
*/
int replacementOffset;
@@ -36,6 +36,8 @@ class CompletionRequestImpl implements CompletionRequest {
* The length of the text to be replaced if the remainder of the identifier
* containing the cursor is to be replaced when the suggestion is applied
* (that is, the number of characters in the existing identifier).
+ * This will be different than the [replacementOffset] - [offset]
+ * if the [offset] is in the middle of an existing identifier.
*/
int replacementLength;

Powered by Google App Engine
This is Rietveld 408576698