pkg/analyzer/tool/task_dependency_graph/generate.dart - Issue 1536043002: - Fix more bad uses of Platform.packageRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/tool/task_dependency_graph/generate.dart

Issue 1536043002: - Fix more bad uses of Platform.packageRoot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/tool/task_dependency_graph/generate.dart

diff --git a/pkg/analyzer/tool/task_dependency_graph/generate.dart b/pkg/analyzer/tool/task_dependency_graph/generate.dart

index 91560b27ce17d7284917174a83ed981ffba3f279..9b960f3d4e0e31d0b8f49b2ad194147475c67a7a 100644

--- a/pkg/analyzer/tool/task_dependency_graph/generate.dart

+++ b/pkg/analyzer/tool/task_dependency_graph/generate.dart

@@ -127,9 +127,8 @@ class Driver {

DartSdk sdk = DirectoryBasedDartSdk.defaultSdk;

context = AnalysisEngine.instance.createAnalysisContext();

String packageRootPath;

- if (Platform.packageRoot.isNotEmpty) {

- Uri packageRootUri = Uri.parse(Platform.packageRoot);

- packageRootPath = packageRootUri.toFilePath();

+ if (Platform.packageRoot != null) {

+ packageRootPath = Uri.parse(Platform.packageRoot).toFilePath();

} else {

packageRootPath = path.join(rootDir, 'packages');

}