Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1536043002: - Fix more bad uses of Platform.packageRoot. (Closed)

Created:
5 years ago by Ivan Posva
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix more bad uses of Platform.packageRoot. - Simplify previous fixes. BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/7e6d5a579d7393549e8c69e353649817cb4ba474

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/incremental/hello_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/precompilation_dart2js_test.dart View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Ivan Posva
TBR
5 years ago (2015-12-18 16:10:22 UTC) #2
Lasse Reichstein Nielsen
LGTM https://codereview.chromium.org/1536043002/diff/1/tests/standalone/precompilation_dart2js_test.dart File tests/standalone/precompilation_dart2js_test.dart (right): https://codereview.chromium.org/1536043002/diff/1/tests/standalone/precompilation_dart2js_test.dart#newcode46 tests/standalone/precompilation_dart2js_test.dart:46: var abs_package_root = Uri.parse(Platform.packageRoot).toFilePath(); This code will still ...
5 years ago (2015-12-18 16:17:51 UTC) #4
Ivan Posva
Committed patchset #1 (id:1) manually as 7e6d5a579d7393549e8c69e353649817cb4ba474 (presubmit successful).
5 years ago (2015-12-18 16:34:11 UTC) #6
rmacnak
5 years ago (2015-12-18 18:28:01 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698