Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Side by Side Diff: chrome/browser/background_sync/background_sync_controller_impl_unittest.cc

Issue 1536023002: [BackgroundSync] Add max sync event duration to BackgroundSyncParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sync_time2
Patch Set: Rename a constant to match the others Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/background_sync/background_sync_controller_impl.h" 5 #include "chrome/browser/background_sync/background_sync_controller_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "chrome/test/base/testing_profile.h" 10 #include "chrome/test/base/testing_profile.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 content::BackgroundSyncParameters original; 91 content::BackgroundSyncParameters original;
92 content::BackgroundSyncParameters overrides; 92 content::BackgroundSyncParameters overrides;
93 controller_->GetParameterOverrides(&overrides); 93 controller_->GetParameterOverrides(&overrides);
94 EXPECT_EQ(original, overrides); 94 EXPECT_EQ(original, overrides);
95 } 95 }
96 96
97 TEST_F(BackgroundSyncControllerImplTest, SomeParamsSet) { 97 TEST_F(BackgroundSyncControllerImplTest, SomeParamsSet) {
98 std::map<std::string, std::string> field_parameters; 98 std::map<std::string, std::string> field_parameters;
99 field_parameters[BackgroundSyncControllerImpl::kDisabledParameterName] = 99 field_parameters[BackgroundSyncControllerImpl::kDisabledParameterName] =
100 "TrUe"; 100 "TrUe";
101 field_parameters["initial_retry_delay_mins"] = "100"; 101 field_parameters[BackgroundSyncControllerImpl::kInitialRetryParameterName] =
102 "100";
102 ASSERT_TRUE(variations::AssociateVariationParams( 103 ASSERT_TRUE(variations::AssociateVariationParams(
103 BackgroundSyncControllerImpl::kFieldTrialName, kFieldTrialGroup, 104 BackgroundSyncControllerImpl::kFieldTrialName, kFieldTrialGroup,
104 field_parameters)); 105 field_parameters));
105 106
106 content::BackgroundSyncParameters original; 107 content::BackgroundSyncParameters original;
107 content::BackgroundSyncParameters sync_parameters; 108 content::BackgroundSyncParameters sync_parameters;
108 controller_->GetParameterOverrides(&sync_parameters); 109 controller_->GetParameterOverrides(&sync_parameters);
109 EXPECT_TRUE(sync_parameters.disable); 110 EXPECT_TRUE(sync_parameters.disable);
110 EXPECT_EQ(base::TimeDelta::FromMinutes(100), 111 EXPECT_EQ(base::TimeDelta::FromSeconds(100),
111 sync_parameters.initial_retry_delay); 112 sync_parameters.initial_retry_delay);
112 113
113 EXPECT_EQ(original.max_sync_attempts, sync_parameters.max_sync_attempts); 114 EXPECT_EQ(original.max_sync_attempts, sync_parameters.max_sync_attempts);
114 EXPECT_EQ(original.retry_delay_factor, sync_parameters.retry_delay_factor); 115 EXPECT_EQ(original.retry_delay_factor, sync_parameters.retry_delay_factor);
115 EXPECT_EQ(original.min_sync_recovery_time, 116 EXPECT_EQ(original.min_sync_recovery_time,
116 sync_parameters.min_sync_recovery_time); 117 sync_parameters.min_sync_recovery_time);
118 EXPECT_EQ(original.max_sync_event_duration,
119 sync_parameters.max_sync_event_duration);
117 } 120 }
118 121
119 TEST_F(BackgroundSyncControllerImplTest, AllParamsSet) { 122 TEST_F(BackgroundSyncControllerImplTest, AllParamsSet) {
120 std::map<std::string, std::string> field_parameters; 123 std::map<std::string, std::string> field_parameters;
121 field_parameters[BackgroundSyncControllerImpl::kDisabledParameterName] = 124 field_parameters[BackgroundSyncControllerImpl::kDisabledParameterName] =
122 "FALSE"; 125 "FALSE";
123 field_parameters[BackgroundSyncControllerImpl::kInitialRetryParameterName] = 126 field_parameters[BackgroundSyncControllerImpl::kInitialRetryParameterName] =
124 "100"; 127 "100";
125 field_parameters[BackgroundSyncControllerImpl::kMaxAttemptsParameterName] = 128 field_parameters[BackgroundSyncControllerImpl::kMaxAttemptsParameterName] =
126 "200"; 129 "200";
127 field_parameters 130 field_parameters
128 [BackgroundSyncControllerImpl::kRetryDelayFactorParameterName] = "300"; 131 [BackgroundSyncControllerImpl::kRetryDelayFactorParameterName] = "300";
129 field_parameters[BackgroundSyncControllerImpl::kMinSyncRecoveryTimeName] = 132 field_parameters[BackgroundSyncControllerImpl::kMinSyncRecoveryTimeName] =
130 "8000000000000"; // something larger than int32_t. 133 "400";
134 field_parameters[BackgroundSyncControllerImpl::kMaxSyncEventDurationName] =
135 "500";
131 ASSERT_TRUE(variations::AssociateVariationParams( 136 ASSERT_TRUE(variations::AssociateVariationParams(
132 BackgroundSyncControllerImpl::kFieldTrialName, kFieldTrialGroup, 137 BackgroundSyncControllerImpl::kFieldTrialName, kFieldTrialGroup,
133 field_parameters)); 138 field_parameters));
134 139
135 content::BackgroundSyncParameters sync_parameters; 140 content::BackgroundSyncParameters sync_parameters;
136 controller_->GetParameterOverrides(&sync_parameters); 141 controller_->GetParameterOverrides(&sync_parameters);
137 142
138 EXPECT_FALSE(sync_parameters.disable); 143 EXPECT_FALSE(sync_parameters.disable);
139 EXPECT_EQ(base::TimeDelta::FromMinutes(100), 144 EXPECT_EQ(base::TimeDelta::FromSeconds(100),
140 sync_parameters.initial_retry_delay); 145 sync_parameters.initial_retry_delay);
141 EXPECT_EQ(200, sync_parameters.max_sync_attempts); 146 EXPECT_EQ(200, sync_parameters.max_sync_attempts);
142 EXPECT_EQ(300, sync_parameters.retry_delay_factor); 147 EXPECT_EQ(300, sync_parameters.retry_delay_factor);
143 EXPECT_EQ(base::TimeDelta::FromMilliseconds(8000000000000), 148 EXPECT_EQ(base::TimeDelta::FromSeconds(400),
144 sync_parameters.min_sync_recovery_time); 149 sync_parameters.min_sync_recovery_time);
150 EXPECT_EQ(base::TimeDelta::FromSeconds(500),
151 sync_parameters.max_sync_event_duration);
145 } 152 }
146 153
147 } // namespace 154 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698