[BackgroundSync] Add max sync event duration to BackgroundSyncParameters

chrome/browser/background_sync/background_sync_controller_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background_sync/background_sync_controller_impl.h"
 
 #include "chrome/test/base/testing_profile.h"
 #include "components/rappor/test_rappor_service.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/background_sync_parameters.h"
@@ skipping 93 matching lines @@
   content::BackgroundSyncParameters sync_parameters;
   controller_->GetParameterOverrides(&sync_parameters);
   EXPECT_TRUE(sync_parameters.disable);
   EXPECT_EQ(base::TimeDelta::FromMinutes(100),
             sync_parameters.initial_retry_delay);
 
   EXPECT_EQ(original.max_sync_attempts, sync_parameters.max_sync_attempts);
   EXPECT_EQ(original.retry_delay_factor, sync_parameters.retry_delay_factor);
   EXPECT_EQ(original.min_sync_recovery_time,
             sync_parameters.min_sync_recovery_time);
+  EXPECT_EQ(original.max_sync_event_duration,
+            sync_parameters.max_sync_event_duration);
 }
 
 TEST_F(BackgroundSyncControllerImplTest, AllParamsSet) {
   std::map<std::string, std::string> field_parameters;
   field_parameters[BackgroundSyncControllerImpl::kDisabledParameterName] =
       "FALSE";
   field_parameters[BackgroundSyncControllerImpl::kInitialRetryParameterName] =
       "100";
   field_parameters[BackgroundSyncControllerImpl::kMaxAttemptsParameterName] =
       "200";
   field_parameters
       [BackgroundSyncControllerImpl::kRetryDelayFactorParameterName] = "300";
   field_parameters[BackgroundSyncControllerImpl::kMinSyncRecoveryTimeName] =
-      "8000000000000";  // something larger than int32.

[davidben, 2015/12/19 00:28:25]

Did you mean to lose that part of the test?

[jkarlin, 2015/12/28 15:51:29]

Yeah, there is no need for it to be an int64. Also changed to int in the field
trial parsing code.

+      "400";
+  field_parameters[BackgroundSyncControllerImpl::kMaxSyncEventDuration] = "500";
   ASSERT_TRUE(variations::AssociateVariationParams(
       BackgroundSyncControllerImpl::kFieldTrialName, kFieldTrialGroup,
       field_parameters));
 
   content::BackgroundSyncParameters sync_parameters;
   controller_->GetParameterOverrides(&sync_parameters);
 
   EXPECT_FALSE(sync_parameters.disable);
   EXPECT_EQ(base::TimeDelta::FromMinutes(100),
             sync_parameters.initial_retry_delay);
   EXPECT_EQ(200, sync_parameters.max_sync_attempts);
   EXPECT_EQ(300, sync_parameters.retry_delay_factor);
-  EXPECT_EQ(base::TimeDelta::FromMilliseconds(8000000000000),
+  EXPECT_EQ(base::TimeDelta::FromMilliseconds(400),
             sync_parameters.min_sync_recovery_time);
+  EXPECT_EQ(base::TimeDelta::FromSeconds(500),
+            sync_parameters.max_sync_event_duration);
 }
 
 }  // namespace