[BackgroundSync] Add max sync event duration to BackgroundSyncParameters

chrome/browser/background_sync/background_sync_controller_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background_sync/background_sync_controller_impl.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 10 matching lines @@
 const char BackgroundSyncControllerImpl::kFieldTrialName[] = "BackgroundSync";
 const char BackgroundSyncControllerImpl::kDisabledParameterName[] = "disabled";
 const char BackgroundSyncControllerImpl::kMaxAttemptsParameterName[] =
     "max_sync_attempts";
 const char BackgroundSyncControllerImpl::kInitialRetryParameterName[] =
     "initial_retry_delay_mins";
 const char BackgroundSyncControllerImpl::kRetryDelayFactorParameterName[] =
     "retry_delay_factor";
 const char BackgroundSyncControllerImpl::kMinSyncRecoveryTimeName[] =
     "min_recovery_time_ms";
+const char BackgroundSyncControllerImpl::kMaxSyncEventDuration[] =
+    "max_sync_event_duration_sec";
 
 BackgroundSyncControllerImpl::BackgroundSyncControllerImpl(Profile* profile)
     : profile_(profile) {}
 
 BackgroundSyncControllerImpl::~BackgroundSyncControllerImpl() = default;
 
 void BackgroundSyncControllerImpl::GetParameterOverrides(
     content::BackgroundSyncParameters* parameters) const {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
@@ skipping 33 matching lines @@
 
   if (ContainsKey(field_params, kMinSyncRecoveryTimeName)) {
     int64_t min_sync_recovery_time_ms;
     if (base::StringToInt64(field_params[kMinSyncRecoveryTimeName],
                             &min_sync_recovery_time_ms)) {
       parameters->min_sync_recovery_time =
           base::TimeDelta::FromMilliseconds(min_sync_recovery_time_ms);
     }
   }
 
+  if (ContainsKey(field_params, kMaxSyncEventDuration)) {
+    int64_t max_sync_event_duration_sec;
+    if (base::StringToInt64(field_params[kMaxSyncEventDuration],

[iclelland, 2015/12/21 19:50:15]

I think this should be StringToInt (and `int max_sync_event_duration_sec` rather
than int64_t), to match the processing of initial_retry_delay_min, and the int
constant defined in background_sync_parameters.cc.

[jkarlin, 2015/12/28 15:51:29]

Done.

+                            &max_sync_event_duration_sec)) {
+      parameters->max_sync_event_duration =
+          base::TimeDelta::FromSeconds(max_sync_event_duration_sec);
+    }
+  }
+
   return;
 }
 
 void BackgroundSyncControllerImpl::NotifyBackgroundSyncRegistered(
     const GURL& origin) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK_EQ(origin, origin.GetOrigin());
 
   if (profile_->IsOffTheRecord())
     return;
@@ skipping 12 matching lines @@
   BackgroundSyncLauncherAndroid::LaunchBrowserIfStopped(enabled, min_ms);
 #else
 // TODO(jkarlin): Use BackgroundModeManager to enter background mode. See
 // https://crbug.com/484201.
 #endif
 }
 
 rappor::RapporService* BackgroundSyncControllerImpl::GetRapporService() {
   return g_browser_process->rappor_service();
 }