Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1536013003: Move SkAndroidSDKCanvas to tools and ensure that it is built on all Android builds (Closed)

Created:
5 years ago by djsollen
Modified:
5 years ago
Reviewers:
reed1, mtklein, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkAndroidSDKCanvas to tools and ensure that it is built on all Android builds GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1536013003 Committed: https://skia.googlesource.com/skia/+/14d8fa0f58bf7f814901d2ae068af8814d6ed1a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -493 lines) Patch
M gyp/bench.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/dm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +25 lines, -0 lines 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D src/utils/android/SkAndroidSDKCanvas.h View 1 chunk +0 lines, -110 lines 0 comments Download
D src/utils/android/SkAndroidSDKCanvas.cpp View 1 chunk +0 lines, -365 lines 0 comments Download
A + tools/android/SkAndroidSDKCanvas.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/android/SkAndroidSDKCanvas.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
djsollen
5 years ago (2015-12-18 16:37:31 UTC) #3
mtklein
lgtm
5 years ago (2015-12-18 16:44:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536013003/1
5 years ago (2015-12-18 16:50:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-18 17:34:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/14d8fa0f58bf7f814901d2ae068af8814d6ed1a4

Powered by Google App Engine
This is Rietveld 408576698