VM: Remove non-existent/unused functions from precompiled entry points.

VM: Remove non-existent/unused functions from precompiled entry points.

These are not present / or not used currently.

Also remove associated native functions from vm-service.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b042cd9a9a0842844516c6244dffa83c9f482803

[Florian Schneider, 2015-12-18 13:47:32]

fschneider@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com

[Florian Schneider, 2015-12-18 13:47:32]

I found these by the warning from --trace-precompiler. 

@rmacnak: Should we maybe make it an error, if an entry point is not found
instead?

@johnmccutchan: Is this really dead code?

[rmacnak, 2015-12-18 18:49:57]

LGTM

It should be possible to make a missing entry an error now. The motivation for
making it a warning had to do with the main isolate missing service library
entries, but that's no longer the case.

https://chromiumcodereview.appspot.com/1536003002/diff/1/runtime/bin/vmservic...
File runtime/bin/vmservice_impl.cc (left):

https://chromiumcodereview.appspot.com/1536003002/diff/1/runtime/bin/vmservic...
runtime/bin/vmservice_impl.cc:92: void TriggerResourceLoad(Dart_NativeArguments
args) {
Remove also the friend declaration from bin/vmservice_impl.h

[Florian Schneider, 2016-01-04 11:20:39]

On 2015/12/18 18:49:57, rmacnak wrote:
> LGTM
> 
> It should be possible to make a missing entry an error now. The motivation for
> making it a warning had to do with the main isolate missing service library
> entries, but that's no longer the case.
> 

I still get a warning with the vmservice_io library:

WARNING: Missing dart:vmservice_io

when running standalone/noopt_test - so I didn't make it a fatal error yet.

>
https://chromiumcodereview.appspot.com/1536003002/diff/1/runtime/bin/vmservic...
> File runtime/bin/vmservice_impl.cc (left):
> 
>
https://chromiumcodereview.appspot.com/1536003002/diff/1/runtime/bin/vmservic...
> runtime/bin/vmservice_impl.cc:92: void
TriggerResourceLoad(Dart_NativeArguments
> args) {
> Remove also the friend declaration from bin/vmservice_impl.h

[Florian Schneider, 2016-01-04 11:20:53]

https://codereview.chromium.org/1536003002/diff/1/runtime/bin/vmservice_impl.cc
File runtime/bin/vmservice_impl.cc (left):

https://codereview.chromium.org/1536003002/diff/1/runtime/bin/vmservice_impl....
runtime/bin/vmservice_impl.cc:92: void TriggerResourceLoad(Dart_NativeArguments
args) {
On 2015/12/18 18:49:57, rmacnak wrote:
> Remove also the friend declaration from bin/vmservice_impl.h

Done.

[Florian Schneider, 2016-01-04 11:41:21]

Description was changed from

==========
VM: Remove non-existent/unused functions from precompiled entry points.

These are not present / or not used currently.

Also remove associated native functions from vm-service.

BUG=
==========

to

==========
VM: Remove non-existent/unused functions from precompiled entry points.

These are not present / or not used currently.

Also remove associated native functions from vm-service.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b042cd9a9a0842844516c6244dffa83c9f482803
==========

[Florian Schneider, 2016-01-04 11:41:23]

Committed patchset #3 (id:40001) manually as
b042cd9a9a0842844516c6244dffa83c9f482803 (presubmit successful).