Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1535983002: ServiceWorker: Factor out functions to collect client information from ServiceWorkerVersion (Closed)

Created:
5 years ago by nhiroki
Modified:
4 years, 11 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Factor out functions to collect client information from ServiceWorkerVersion Functions for collecting client information (GetWindowClients etc) are not related to Service Worker lifecycle and it is not neccessary to put them in ServiceWorkerVersion that is the core class to manage the lifecycle. For improving readability and maintainability, this patch factors out the functions into a separate file. This should not change behavior of them. In addition, this patch renames service_worker_client_navigation_utils namespace to service_worker_client_utils because this namespace now contains functions not related to navigation. BUG=570223 Committed: https://crrev.com/910fc8840b56c94f2a172b3ae7b5c1b3b5108985 Cr-Commit-Position: refs/heads/master@{#367485}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -452 lines) Patch
M content/browser/service_worker/service_worker_client_navigation_utils.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/service_worker/service_worker_client_navigation_utils.cc View 1 1 chunk +0 lines, -234 lines 0 comments Download
A + content/browser/service_worker/service_worker_client_utils.h View 3 chunks +16 lines, -5 lines 0 comments Download
A + content/browser/service_worker/service_worker_client_utils.cc View 1 4 chunks +166 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 chunks +5 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 10 chunks +7 lines, -151 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
nhiroki
PTAL, thanks!
5 years ago (2015-12-22 12:46:49 UTC) #11
falken
Thanks for cleaning up SWVersion! lgtm
4 years, 11 months ago (2016-01-05 05:10:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535983002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535983002/120001
4 years, 11 months ago (2016-01-05 05:12:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 11 months ago (2016-01-05 05:16:36 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 05:17:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/910fc8840b56c94f2a172b3ae7b5c1b3b5108985
Cr-Commit-Position: refs/heads/master@{#367485}

Powered by Google App Engine
This is Rietveld 408576698