third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp - Issue 1535943005: Initial implementation of bindings and basic classes for worklets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 1535943005: Initial implementation of bindings and basic classes for worklets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address (most) comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp ('K') | « third_party/WebKit/Source/core/dom/ExecutionContext.h ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

index 621e0af8dd096e24487690ef01c494d5c0908fa8..12abcde0e88a5816c99ece1f92294ce17ef2e696 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

@@ -74,7 +74,7 @@ WorkerGlobalScope::WorkerGlobalScope(const KURL& url, const String& userAgent, W

: m_url(url)

, m_userAgent(userAgent)

, m_v8CacheOptions(V8CacheOptionsDefault)

- , m_script(WorkerOrWorkletScriptController::create(this, thread->isolate()))

+ , m_script(WorkerOrWorkletScriptController::create(this, this, thread->isolate()))

, m_thread(thread)

, m_workerInspectorController(adoptRefWillBeNoop(new WorkerInspectorController(this)))

, m_closing(false)