third_party/WebKit/Source/bindings/core/v8/ToV8.cpp - Issue 1535943005: Initial implementation of bindings and basic classes for worklets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

Issue 1535943005: Initial implementation of bindings and basic classes for worklets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove AbstractGlobalScope. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/GlobalScopeScriptController.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ModuleProxy.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp b/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

index a8cd968ebc7a82d318790950385df5251f1815ba..8126fc4b53710edba0c5c9cd7046d71722945801 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8.cpp

@@ -50,7 +50,7 @@ v8::Local<v8::Value> toV8(WorkerGlobalScope* impl, v8::Local<v8::Object> creatio

if (UNLIKELY(!impl))

return v8::Null(isolate);

- WorkerScriptController* script = impl->script();

+ GlobalScopeScriptController* script = impl->script();

kinuko 2015/12/24 04:45:51 This toV8 method takes WorkerGlobalScope, should t

if (!script)

return v8::Null(isolate);