third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp - Issue 1535943005: Initial implementation of bindings and basic classes for worklets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 1535943005: Initial implementation of bindings and basic classes for worklets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix memory leak. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h ('K') | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

index 67c7f9f572ecfeabc986da14a803e33784dcd33c..30aba074175246352ec7fa93bd3b24ee85ddda69 100644

--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

@@ -189,7 +189,7 @@ public:

private:

void executeScriptInWorker(WorkerThread* worker, WebWaitableEvent* waitEvent)

{

- WorkerScriptController* scriptController = worker->workerGlobalScope()->script();

+ GlobalScopeScriptController* scriptController = worker->workerGlobalScope()->script();

bool evaluateResult = scriptController->evaluate(ScriptSourceCode("var counter = 0; ++counter;"));

ASSERT_UNUSED(evaluateResult, evaluateResult);

waitEvent->signal();