third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp - Issue 1535943005: Initial implementation of bindings and basic classes for worklets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

Issue 1535943005: Initial implementation of bindings and basic classes for worklets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix memory leak. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.h » ('j') | third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

index ccbc66302ee66277c853736ade0b38353556031f..d262de86ce24f8a7fd92129a7fb933819c02dfdc 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

@@ -32,13 +32,13 @@

#include "bindings/core/v8/V8WorkerGlobalScopeEventListener.h"

+#include "bindings/core/v8/GlobalScopeScriptController.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8DOMWrapper.h"

#include "bindings/core/v8/V8Event.h"

#include "bindings/core/v8/V8EventTarget.h"

#include "bindings/core/v8/V8GCController.h"

#include "bindings/core/v8/V8ScriptRunner.h"

-#include "bindings/core/v8/WorkerScriptController.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/InspectorTraceEvents.h"

#include "core/workers/WorkerGlobalScope.h"

@@ -56,7 +56,7 @@ void V8WorkerGlobalScopeEventListener::handleEvent(ScriptState* scriptState, Eve

// See issue 889829.

RefPtrWillBeRawPtr<V8AbstractEventListener> protect(this);

- WorkerScriptController* script = toWorkerGlobalScope(scriptState->executionContext())->script();

+ GlobalScopeScriptController* script = toWorkerGlobalScope(scriptState->executionContext())->script();

if (!script)

return;