mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h - Issue 1535943002: Convert Pass()→std::move() in //mojo/public/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h

Issue 1535943002: Convert Pass()→std::move() in //mojo/public/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove self-move checks to avoid triggering clang warning. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h

diff --git a/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h b/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h

index 00f2de5fb5846742f5c86c7c2d808ff61a57fcff..ef2fa75df006d24bd74e672177fedc1b7ac851ad 100644

--- a/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h

+++ b/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h

@@ -6,6 +6,7 @@

#define MOJO_PUBLIC_CPP_BINDINGS_LIB_ASSOCIATED_INTERFACE_PTR_STATE_H_

#include <algorithm> // For |std::swap()|.

+#include <utility>

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

@@ -94,7 +95,7 @@ class AssociatedInterfacePtrState {

AssociatedInterfacePtrInfo<GenericInterface> result;

result.set_version(version_);

- AssociatedInterfacePtrInfoHelper::SetHandle(&result, handle.Pass());

+ AssociatedInterfacePtrInfoHelper::SetHandle(&result, std::move(handle));

return result.Pass();

}