Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1535933002: Revert of [heap] delete Heap::LeftTrimFixedAray (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] delete Heap::LeftTrimFixedAray Reason for revert: Revive left-trimming until new strategies are evaluated and decided on. Partially reverted changes from: https://codereview.chromium.org/1474203003/ BUG=v8:4606 LOG=N Original issue's description: > [heap] delete Heap::LeftTrimFixedAray > > No more uses left for this code (thank goodness.) > > R=hpayer@chromium.org > BUG= > > Committed: https://crrev.com/dc3442b1ec803916eb6c1882ab4c3ec6fd44dd55 > Cr-Commit-Position: refs/heads/master@{#32305} TBR=hpayer@chromium.org,ofrobots@google.com Committed: https://crrev.com/e5015918e98657507c772a591c4627595fc2c779 Cr-Commit-Position: refs/heads/master@{#32965}

Patch Set 1 : Baseline #

Patch Set 2 : Bring back GreyToWhite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
src/heap/heap.h View 1 chunk +6 lines, -0 lines 0 comments Download
src/heap/heap.cc View 2 chunks +67 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +8 lines, -0 lines 0 comments Download
src/heap/mark-compact.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Lippautz
Created Revert of [heap] delete Heap::LeftTrimFixedAray
5 years ago (2015-12-18 08:36:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535933002/1
5 years ago (2015-12-18 08:39:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/11402) v8_mac_rel on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-18 08:42:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535933002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535933002/140001
5 years ago (2015-12-18 09:00:37 UTC) #10
Hannes Payer (out of office)
lgtm
5 years ago (2015-12-18 09:14:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:140001)
5 years ago (2015-12-18 09:48:47 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-18 09:49:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5015918e98657507c772a591c4627595fc2c779
Cr-Commit-Position: refs/heads/master@{#32965}

Powered by Google App Engine
This is Rietveld 408576698