Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: chrome/common/extensions/api/socket.idl

Issue 15359007: Allow missing socketType in SocketInfo if socket is not connected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes as per asargent Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/socket.idl
diff --git a/chrome/common/extensions/api/socket.idl b/chrome/common/extensions/api/socket.idl
index 4bc60680e971f66962846c70791350475f193b8d..43c073275d6d305d559ac96038a6aed10a701a65 100644
--- a/chrome/common/extensions/api/socket.idl
+++ b/chrome/common/extensions/api/socket.idl
@@ -110,7 +110,7 @@ namespace socket {
callback SetNoDelayCallback = void (boolean result);
- callback GetInfoCallback = void (SocketInfo result);
+ callback GetInfoCallback = void (optional SocketInfo result);
asargent_no_longer_on_chrome 2013/05/29 21:31:07 You can actually leave this as non-optional, since
Bei Zhang 2013/05/29 22:14:51 Done.
callback GetNetworkCallback = void (NetworkInterface[] result);
« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api.cc ('k') | chrome/test/data/extensions/api_test/socket/api/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698