Issue 15359006: PNaCl: Fix FlattenGlobals to correctly handle implicitly-aligned variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15359006: PNaCl: Fix FlattenGlobals to correctly handle implicitly-aligned variables (Closed)

Created:
7 years, 7 months ago by Mark Seaborn

Modified:
7 years, 7 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

PNaCl: Fix FlattenGlobals to correctly handle implicitly-aligned variables If a global variable has no "align" attribute, it must be aligned based on its type. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3437 TEST=flatten-globals.ll Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=6aea8b4

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -2 lines)			Patch
	M	lib/Transforms/NaCl/FlattenGlobals.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	test/Transforms/NaCl/flatten-globals.ll	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Seaborn

7 years, 7 months ago (2013-05-20 16:55:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r6aea8b4 (presubmit successful).