Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153583007: Revert "Serialization of SkPictureImageFilter" (Closed)

Created:
6 years, 10 months ago by f(malita)
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Serialization of SkPictureImageFilter" This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e. Revert "Sanitizing source files in Housekeeper-Nightly" This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77. TBR=robertphillips@google.com,sugoi@google.com Committed: https://code.google.com/p/skia/source/detail?r=13356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -251 lines) Patch
M gm/colorfilters.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPicture.h View 4 chunks +1 line, -20 lines 0 comments Download
M include/effects/SkColorMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +1 line, -7 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +1 line, -34 lines 0 comments Download
M src/core/SkPicture.cpp View 5 chunks +17 lines, -89 lines 0 comments Download
M src/core/SkPicturePlayback.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 3 chunks +0 lines, -40 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +2 lines, -16 lines 0 comments Download
M src/image/SkImage.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/MatrixClipCollapseTest.cpp View 20 chunks +36 lines, -36 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fmalita_google_do_not_use
The CQ bit was checked by fmalita@google.com
6 years, 10 months ago (2014-02-07 05:53:21 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 05:53:26 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-07 05:53:27 UTC) #3
f(malita)
Committed patchset #1 manually as r13356.
6 years, 10 months ago (2014-02-07 05:55:46 UTC) #4
rmistry
6 years, 10 months ago (2014-02-07 12:19:50 UTC) #5
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/143163005/ by rmistry@google.com.

The reason for reverting is: New SKPs with version20 are in Google Storage due
to
http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22.

Powered by Google App Engine
This is Rietveld 408576698