Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 153583003: Update remaining references to the NPAPI test plugin (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Visibility:
Public.

Description

Update remaining references to the NPAPI test plugin BUG=331302 R=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/all.gyp View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-04 07:47:25 UTC) #1
tfarina
lgtm. I was going to do this yesterday, but got tired. Thanks!
6 years, 10 months ago (2014-02-04 12:39:40 UTC) #2
tfarina
lgtm. I was going to do this yesterday, but got tired. Thanks!
6 years, 10 months ago (2014-02-04 12:39:40 UTC) #3
tfarina
lgtm. I was going to do this yesterday, but got tired. Thanks!
6 years, 10 months ago (2014-02-04 12:39:40 UTC) #4
tfarina
After this lands, I will remove it from Blink.
6 years, 10 months ago (2014-02-04 12:41:39 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-04 12:41:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/153583003/1
6 years, 10 months ago (2014-02-04 12:42:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 13:16:21 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223120
6 years, 10 months ago (2014-02-04 13:16:21 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-04 14:59:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/153583003/1
6 years, 10 months ago (2014-02-04 14:59:27 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:06:14 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120850
6 years, 10 months ago (2014-02-04 16:06:14 UTC) #13
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:06:15 UTC) #14
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 10 months ago (2014-02-04 16:11:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/153583003/1
6 years, 10 months ago (2014-02-04 16:11:50 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:34:48 UTC) #17
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120928
6 years, 10 months ago (2014-02-04 17:34:49 UTC) #18
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-04 17:58:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/153583003/1
6 years, 10 months ago (2014-02-04 17:58:45 UTC) #20
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r248770 (presubmit successful).
6 years, 10 months ago (2014-02-04 19:25:39 UTC) #21
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
6 years, 10 months ago (2014-02-04 19:28:35 UTC) #22
msw
6 years, 10 months ago (2014-02-04 23:28:31 UTC) #23
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/155153002/ by msw@chromium.org.

The reason for reverting is: Caused a build break:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

File
/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/plugins/TestNetscapePlugIn.plugin
doesn't exist.

Powered by Google App Engine
This is Rietveld 408576698