Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1535803005: Fix task manager table scrollbar issue. (Closed)

Created:
5 years ago by afakhry
Modified:
5 years ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix task manager table scrollbar issue. On startup of the task manager, when the running tasks on the system are stabilized (i.e. no new addition or removal of tasks), the vertical scrollbar doesn't show up. TableView::OnModelChanged() needed to be invoked on startup. BUG=570966 TEST=manually on a pixel. Wait for tasks to stabilize and open the task manager. The vertical scrollbar should show up. Committed: https://crrev.com/632d28b52e4e7846a867ed47bdb4eb3e440cea5a Cr-Commit-Position: refs/heads/master@{#366425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/task_manager/task_manager_table_model.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
afakhry
Hey Nick! Please review. Thanks!
5 years ago (2015-12-18 22:59:09 UTC) #2
ncarter (slow)
lgtm
5 years ago (2015-12-21 17:44:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535803005/1
5 years ago (2015-12-21 17:45:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 18:44:24 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years ago (2015-12-21 18:44:46 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-21 18:45:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/632d28b52e4e7846a867ed47bdb4eb3e440cea5a
Cr-Commit-Position: refs/heads/master@{#366425}

Powered by Google App Engine
This is Rietveld 408576698