Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 1535803003: Add two UseCounters for form.imageName and form.elements.imageName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
index 6cd1c1e4f59c4b9dd881a8e98f8bbc972120c3f2..adf06a7cff142b776642dd42e500dbc0ca10f474 100644
--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
@@ -837,8 +837,17 @@ void HTMLFormElement::anonymousNamedGetter(const AtomicString& name, RadioNodeLi
ASSERT(!elements.isEmpty());
bool onlyMatchImg = !elements.isEmpty() && isHTMLImageElement(*elements.first());
- if (onlyMatchImg)
+ if (onlyMatchImg) {
UseCounter::count(document(), UseCounter::FormNameAccessForImageElement);
+ // The following code has performance impact, but it should be small
+ // because <img> access via <form> name getter is rarely used.
+ for (auto& element : elements) {
+ if (isHTMLImageElement(*element) && !element->isDescendantOf(this)) {
+ UseCounter::count(document(), UseCounter::FormNameAccessForNonDescendantImageElement);
+ break;
+ }
+ }
+ }
if (elements.size() == 1) {
returnValue.setElement(elements.at(0));
return;
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698