Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1535793004: fix stroked text underline / strikethrough (Closed)

Created:
5 years ago by caryclark
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix stroked text underline / strikethrough Pass 1 to DrawRect for underline and strikethrough since it will scale by the text size later. R=reed@google.com BUG=skia:971 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1535793004 Committed: https://skia.googlesource.com/skia/+/fb56218292d6c7b509d382f39994c3783b2483a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M gm/texteffects.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
caryclark
5 years ago (2015-12-18 21:27:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535793004/1
5 years ago (2015-12-18 21:27:38 UTC) #4
reed1
lgtm crazy bug that we hadn't seen this before. Does anyone call this with something ...
5 years ago (2015-12-18 21:50:18 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 22:26:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535793004/1
5 years ago (2015-12-21 16:20:04 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-21 16:35:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb56218292d6c7b509d382f39994c3783b2483a0

Powered by Google App Engine
This is Rietveld 408576698