Issue 1535743002: - Make sure that externals are patched for dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1535743002: - Make sure that externals are patched for dart2js. (Closed)

Created:
5 years ago by Ivan Posva

Modified:
5 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Make sure that externals are patched for dart2js. - Remove unneeded native entry points. BUG= Committed: https://github.com/dart-lang/sdk/commit/e6514527593ce8d70b4380fb5784885b4371ff25

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -22 lines)			Patch
M	runtime/bin/io_natives.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/main.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/platform.h	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	runtime/bin/platform.cc	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/io_patch.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Ivan Posva

Committed patchset #2 (id:20001) manually as e6514527593ce8d70b4380fb5784885b4371ff25 (presubmit successful).

5 years ago (2015-12-17 16:26:14 UTC) #4

Message was sent while issue was closed.

lgtm