Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1535713002: Give ScopedJavaGlobalRef copy and assignment constructors (Closed)

Created:
5 years ago by aberent
Modified:
5 years ago
Reviewers:
Torne
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give ScopedJavaGlobalRef copy and assignment constructors These are needed to allow its use as a bound argument in base::Bind. BUG=none Committed: https://crrev.com/e6c87d5c00f4cc895173b967d7b02c083d6c964e Cr-Commit-Position: refs/heads/master@{#365816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/android/scoped_java_ref.h View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
aberent
5 years ago (2015-12-17 12:18:27 UTC) #2
Torne
lgtm
5 years ago (2015-12-17 12:20:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535713002/1
5 years ago (2015-12-17 12:20:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 13:35:17 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 13:36:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6c87d5c00f4cc895173b967d7b02c083d6c964e
Cr-Commit-Position: refs/heads/master@{#365816}

Powered by Google App Engine
This is Rietveld 408576698