Refactor the IsKeyboardPresentOnSlate function.

Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function. One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+ and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role. As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that the OSK pops up by default.

BUG=497381
TBR=sky

Committed: https://crrev.com/44366f4e8c4970cb49d47c3b38063a5ae01b989a
Cr-Commit-Position: refs/heads/master@{#368241}

[ananta, 2015-12-19 02:33:41]

ananta@chromium.org changed reviewers:
+ jschuh@chromium.org

[jschuh, 2016-01-07 01:18:40]

Sorry for the delay.

https://codereview.chromium.org/1535643006/diff/1/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/1535643006/diff/1/base/win/win_util.cc#newcod...
base/win/win_util.cc:105: HMODULE power_prof_module =
::GetModuleHandle(L"powrprof.dll");
Skip the dynamic loads and just do a version check, because powrprof.dll is
already delay loaded anyway.

https://codereview.chromium.org/1535643006/diff/1/base/win/win_util.cc#newcod...
base/win/win_util.cc:135: DCHECK(GetVersion() >= VERSION_WIN8);
Keep the old code here, because it's called from
ChromeInternalLogSource::PopulateUsbKeyboardDetected().

[ananta, 2016-01-07 22:41:05]

https://codereview.chromium.org/1535643006/diff/1/base/win/win_util.cc
File base/win/win_util.cc (right):

https://codereview.chromium.org/1535643006/diff/1/base/win/win_util.cc#newcod...
base/win/win_util.cc:105: HMODULE power_prof_module =
::GetModuleHandle(L"powrprof.dll");
On 2016/01/07 01:18:40, jschuh (very slow) wrote:
> Skip the dynamic loads and just do a version check, because powrprof.dll is
> already delay loaded anyway.

Done.

https://codereview.chromium.org/1535643006/diff/1/base/win/win_util.cc#newcod...
base/win/win_util.cc:135: DCHECK(GetVersion() >= VERSION_WIN8);
On 2016/01/07 01:18:40, jschuh (very slow) wrote:
> Keep the old code here, because it's called from
> ChromeInternalLogSource::PopulateUsbKeyboardDetected().

Done.

[jschuh, 2016-01-08 00:27:26]

lgtm

[ananta, 2016-01-08 00:39:28]

Description was changed from

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
==========

to

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
==========

[ananta, 2016-01-08 00:39:28]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2016-01-08 00:39:41]

Description was changed from

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
==========

to

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
TBR=sky
==========

[ananta, 2016-01-08 00:39:57]

TBR'ing sky for chrome\browser owners.

[ananta, 2016-01-08 01:40:27]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-01-08 01:41:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535643006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535643006/20001

[commit-bot: I haz the power, 2016-01-08 01:45:48]

Description was changed from

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
TBR=sky
==========

to

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
TBR=sky
==========

[commit-bot: I haz the power, 2016-01-08 01:45:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-08 01:46:52]

Description was changed from

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
TBR=sky
==========

to

==========
Refactor the IsKeyboardPresentOnSlate function.

Currently this function shares the same logic as the IsTabletDevice function.
One of the big differences was the
IsTabletDevice function allows calls from Windows XP. Changed that to Windows 8+
and changed the IsKeyboardPresentOnSlate function
to call IsTabletDevice. The IsTabletDevice function now takes in a reason
argument which is updated with the reason info as to
why the device was deemed to be a tablet or not.

We now use the PowerDeterminePlatformRoleEx API to determine the platform role.
As per msdn this function returns better results on Windows 8+.

Next step would be to see if this function reliably works for tablets and slate
mode. If yes then we can possibly flip the switch
kDisableUsbKeyboardDetect to kEnableUsbKeyboardDetect which would ensure that
the OSK pops up by default.

BUG=497381
TBR=sky

Committed: https://crrev.com/44366f4e8c4970cb49d47c3b38063a5ae01b989a
Cr-Commit-Position: refs/heads/master@{#368241}
==========

[commit-bot: I haz the power, 2016-01-08 01:46:52]

Patchset 2 (id:??) landed as
https://crrev.com/44366f4e8c4970cb49d47c3b38063a5ae01b989a
Cr-Commit-Position: refs/heads/master@{#368241}

[sky, 2016-01-08 16:26:39]

LGTM