Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1535643004: remove extraneous classes and cleanup code (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -108 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 3 chunks +12 lines, -107 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-17 22:49:51 UTC) #2
scheglov
LGTM
5 years ago (2015-12-17 23:06:35 UTC) #3
danrubel
5 years ago (2015-12-18 13:53:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1adabf4abc87a47885510b8464f81f6b309a6e81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698