Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1535613003: X87: [Interpreter] Save bytecode offset in interpreter stack frames. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Save bytecode offset in interpreter stack frames. port 025d476cf57ce8695f8e36906e4863b17c981747 (r32906) original commit message: Adds a slot for the bytecode offset to interpreter stack frames and saves it on calls, and restores after calls. Also fixes RawMachineAssembler::Return() to call MergeControlToEnd. BUG= Committed: https://crrev.com/da4a7325c0870584ad9caec072a58379ff7363d6 Cr-Commit-Position: refs/heads/master@{#32922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-17 02:35:50 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-17 02:58:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535613003/1
5 years ago (2015-12-17 02:58:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 04:45:55 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 04:46:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da4a7325c0870584ad9caec072a58379ff7363d6
Cr-Commit-Position: refs/heads/master@{#32922}

Powered by Google App Engine
This is Rietveld 408576698