http 'new' opens 2 tabs when there are no windows on cros.

chrome/browser/devtools/browser_list_tabcontents_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/browser_list_tabcontents_provider.h"
 
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/history/top_sites.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
 #include "grit/devtools_discovery_page_resources.h"
 #include "net/socket/tcp_listen_socket.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using content::DevToolsHttpHandlerDelegate;
 using content::RenderViewHost;
 
 BrowserListTabContentsProvider::BrowserListTabContentsProvider(
     Profile* profile,
     chrome::HostDesktopType host_desktop_type)
-    : profile_(profile), host_desktop_type_(host_desktop_type) {
+    : profile_(profile->GetOriginalProfile()),

[Tim Song, 2013/05/20 22:48:41]

If the profile being passed in here is an incognito profile, and this is not
expected, shouldn't there be a problem in whatever is creating this object?

[achuithb, 2013/05/20 23:10:00]

Yup, that's here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

I haven't investigated this

+      host_desktop_type_(host_desktop_type) {
 }
 
 BrowserListTabContentsProvider::~BrowserListTabContentsProvider() {
 }
 
 std::string BrowserListTabContentsProvider::GetDiscoveryPageHTML() {
   std::set<Profile*> profiles;
   for (chrome::BrowserIterator it; !it.done(); it.Next())
     profiles.insert((*it)->profile());
 
@@ skipping 37 matching lines @@
           reinterpret_cast<const char*>(data->front()), data->size());
   }
 
   return std::string();
 }
 
 RenderViewHost* BrowserListTabContentsProvider::CreateNewTarget() {
   const BrowserList* browser_list =
       BrowserList::GetInstance(host_desktop_type_);
 
-  if (browser_list->empty())
+  if (browser_list->empty()) {
     chrome::NewEmptyWindow(profile_, host_desktop_type_);
-
-  if (browser_list->empty())
-    return NULL;
+    return browser_list->empty() ? NULL :
+           browser_list->get(0)->tab_strip_model()->GetActiveWebContents()->
+               GetRenderViewHost();

[Tim Song, 2013/05/20 22:48:41]

This is good, as we don't want two tabs being open if there is no browser.
However, I'm curious when this happens with telemetry. There is a check in
tools/telemetry/telemetry/core/chrome/tab_list_backend.py that creates a new tab
should the last tab ever be closed.

[achuithb, 2013/05/20 23:10:00]

That code only kicks in when a tab is closed. This is startup code and no
windows/tabs are present when we call this function.

+  }
 
   content::WebContents* web_contents = chrome::AddSelectedTabWithURL(
       browser_list->get(0),
       GURL(content::kAboutBlankURL),
       content::PAGE_TRANSITION_LINK);
   return web_contents->GetRenderViewHost();
 }
 
 content::DevToolsHttpHandlerDelegate::TargetType
 BrowserListTabContentsProvider::GetTargetType(content::RenderViewHost* rvh) {
@@ skipping 40 matching lines @@
   return net::TCPListenSocket::CreateAndListen("127.0.0.1", port, delegate);
 }
 #else
 scoped_refptr<net::StreamListenSocket>
 BrowserListTabContentsProvider::CreateSocketForTethering(
     net::StreamListenSocket::Delegate* delegate,
     std::string* name) {
   return NULL;
 }
 #endif  // defined(DEBUG_DEVTOOLS)