1) Add initialization error page; 2) Add connection error page.

1) Add initialization error page
2) Add connection error page
3) Remove enrollment related local state  settings - kDeviceEnrollmentAutoStart and kDeviceEnrollmentCanExit

BUG=564370
Committed: https://crrev.com/955dbfd99f99649301745489776bb7b793ba0d1d
Cr-Commit-Position: refs/heads/master@{#366014}

[xdai1, 2015-12-16 23:51:39]

Description was changed from

==========
1) Add initialization error page
2) Add connection error page
3) Reset the bluetooth connection whenever an error occurs.

BUG=564370
==========

to

==========
1) Add initialization error page
2) Add connection error page
3) Reset the bluetooth connection on a host device whenever an error occurs.

BUG=564370
==========

[xdai1, 2015-12-17 00:48:24]

Description was changed from

==========
1) Add initialization error page
2) Add connection error page
3) Reset the bluetooth connection on a host device whenever an error occurs.

BUG=564370
==========

to

==========
1) Add initialization error page
2) Add connection error page

BUG=564370
==========

[xdai1, 2015-12-17 00:48:32]

Patchset #1 (id:1) has been deleted

[xdai1, 2015-12-17 00:54:07]

xdai@chromium.org changed reviewers:
+ dzhioev@chromium.org

[xdai1, 2015-12-17 00:54:07]

Pasha, could you help to review this CL please? Thanks!

[xdai1, 2015-12-17 21:45:16]

Description was changed from

==========
1) Add initialization error page
2) Add connection error page

BUG=564370
==========

to

==========
1) Add initialization error page
2) Add connection error page
3) Clear enrollment related local states when then bootstrapping enrollment
succeeds or an error occurs.

BUG=564370
==========

[dzhioev (left Google), 2015-12-17 23:33:32]

https://codereview.chromium.org/1535573002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/1535573002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/wizard_controller.cc:619: } else if
(IsBootstrappingSlave() && shark_controller_detected_) {
What is this change needed for?

https://codereview.chromium.org/1535573002/diff/60001/components/pairing/blue...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/1535573002/diff/60001/components/pairing/blue...
components/pairing/bluetooth_host_pairing_controller.cc:317:
ChangeStage(STAGE_CONTROLLER_CONNECTION_ERROR);
I don't think we should call this if |enrollment_status_| is
ENROLLMENT_STATUS_ENROLLING or ENROLLMENT_STATUS_SUCCESS.

[xdai1, 2015-12-17 23:49:08]

Pasha, I've addressed your comment, please take another look, thanks for your
review.

https://codereview.chromium.org/1535573002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/1535573002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/wizard_controller.cc:619: } else if
(IsBootstrappingSlave() && shark_controller_detected_) {
On 2015/12/17 23:33:32, dzhioev wrote:
> What is this change needed for?

The idea is that we should not show the host pairing screen if there is no valid
controller connected with the Chrome OS device even with the slave flag
specified. In this case, we should fall back to the normal manual enrollment
process.

This way, the Chrome OS device with the slave flag specified behaves the same
way as before if there is no bootstrapping attempt nearby.

https://codereview.chromium.org/1535573002/diff/60001/components/pairing/blue...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/1535573002/diff/60001/components/pairing/blue...
components/pairing/bluetooth_host_pairing_controller.cc:317:
ChangeStage(STAGE_CONTROLLER_CONNECTION_ERROR);
On 2015/12/17 23:33:32, dzhioev wrote:
> I don't think we should call this if |enrollment_status_| is
> ENROLLMENT_STATUS_ENROLLING or ENROLLMENT_STATUS_SUCCESS.

Agreed. Addressed your comment.

[xdai1, 2015-12-18 00:02:55]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 00:08:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535573002/80001

[xdai1, 2015-12-18 00:51:16]

On 2015/12/17 23:49:08, xdai1 wrote:
> Pasha, I've addressed your comment, please take another look, thanks for your
> review.
> 
>
https://codereview.chromium.org/1535573002/diff/60001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/wizard_controller.cc (right):
> 
>
https://codereview.chromium.org/1535573002/diff/60001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/wizard_controller.cc:619: } else if
> (IsBootstrappingSlave() && shark_controller_detected_) {
> On 2015/12/17 23:33:32, dzhioev wrote:
> > What is this change needed for?
> 
> The idea is that we should not show the host pairing screen if there is no
valid
> controller connected with the Chrome OS device even with the slave flag
> specified. In this case, we should fall back to the normal manual enrollment
> process.
> 
> This way, the Chrome OS device with the slave flag specified behaves the same
> way as before if there is no bootstrapping attempt nearby.
> 
>
https://codereview.chromium.org/1535573002/diff/60001/components/pairing/blue...
> File components/pairing/bluetooth_host_pairing_controller.cc (right):
> 
>
https://codereview.chromium.org/1535573002/diff/60001/components/pairing/blue...
> components/pairing/bluetooth_host_pairing_controller.cc:317:
> ChangeStage(STAGE_CONTROLLER_CONNECTION_ERROR);
> On 2015/12/17 23:33:32, dzhioev wrote:
> > I don't think we should call this if |enrollment_status_| is
> > ENROLLMENT_STATUS_ENROLLING or ENROLLMENT_STATUS_SUCCESS.
> 
> Agreed. Addressed your comment.

Pasha, I just realized that we don't need to setup enrollment related flags:
prefs::kDeviceEnrollmentAutoStart and prefs::kDeviceEnrollmentCanExit, since we
don't show Enrollment Screen on the host device anymore. It's a good thing:) We
don't need to clear the enrollment related states.

Please take another look, thanks.

[dzhioev (left Google), 2015-12-18 00:53:02]

LGTM

[xdai1, 2015-12-18 00:59:41]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 01:00:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535573002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535573002/100001

[commit-bot: I haz the power, 2015-12-18 01:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 01:41:53]

Dry run: This issue passed the CQ dry run.

[xdai1, 2015-12-18 04:33:06]

Description was changed from

==========
1) Add initialization error page
2) Add connection error page
3) Clear enrollment related local states when then bootstrapping enrollment
succeeds or an error occurs.

BUG=564370
==========

to

==========
1) Add initialization error page
2) Add connection error page
3) Remove enrollment related local state  settings - kDeviceEnrollmentAutoStart
and kDeviceEnrollmentCanExit 

BUG=564370
==========

[xdai1, 2015-12-18 04:35:43]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2015-12-18 04:35:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535573002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535573002/100001

[commit-bot: I haz the power, 2015-12-18 04:40:53]

Description was changed from

==========
1) Add initialization error page
2) Add connection error page
3) Remove enrollment related local state  settings - kDeviceEnrollmentAutoStart
and kDeviceEnrollmentCanExit 

BUG=564370
==========

to

==========
1) Add initialization error page
2) Add connection error page
3) Remove enrollment related local state  settings - kDeviceEnrollmentAutoStart
and kDeviceEnrollmentCanExit 

BUG=564370
==========

[commit-bot: I haz the power, 2015-12-18 04:40:54]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-12-18 04:41:31]

Description was changed from

==========
1) Add initialization error page
2) Add connection error page
3) Remove enrollment related local state  settings - kDeviceEnrollmentAutoStart
and kDeviceEnrollmentCanExit 

BUG=564370
==========

to

==========
1) Add initialization error page
2) Add connection error page
3) Remove enrollment related local state  settings - kDeviceEnrollmentAutoStart
and kDeviceEnrollmentCanExit

BUG=564370

Committed: https://crrev.com/955dbfd99f99649301745489776bb7b793ba0d1d
Cr-Commit-Position: refs/heads/master@{#366014}
==========

[commit-bot: I haz the power, 2015-12-18 04:41:32]

Patchset 5 (id:??) landed as
https://crrev.com/955dbfd99f99649301745489776bb7b793ba0d1d
Cr-Commit-Position: refs/heads/master@{#366014}