Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1535563002: [Blimp Net] Update engine version (Closed)

Created:
5 years ago by haibinlu
Modified:
5 years ago
CC:
chromium-reviews, dtrainor+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blimp Net] Update engine version It is the same as mobile Chrome. BUG=537367 Committed: https://crrev.com/9f6f3f7994f85a7140dc29eeb9df97a7a797a410 Cr-Commit-Position: refs/heads/master@{#365876}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M blimp/engine/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/common/blimp_content_client.cc View 2 chunks +3 lines, -4 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
haibinlu
5 years ago (2015-12-16 23:27:27 UTC) #2
Wez
LGTM but please consider folding the UA string impl into the GetUserAgent override - can't ...
5 years ago (2015-12-17 02:01:32 UTC) #3
haibinlu
https://codereview.chromium.org/1535563002/diff/1/blimp/engine/common/blimp_content_client.cc File blimp/engine/common/blimp_content_client.cc (right): https://codereview.chromium.org/1535563002/diff/1/blimp/engine/common/blimp_content_client.cc#newcode15 blimp/engine/common/blimp_content_client.cc:15: std::string GetBlimpEngineUserAgent() { On 2015/12/17 02:01:31, Wez wrote: > ...
5 years ago (2015-12-17 02:28:55 UTC) #4
haibinlu
jochen@, could I get your owner review of the DEPS file? Thanks!
5 years ago (2015-12-17 02:33:45 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-17 14:30:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535563002/1
5 years ago (2015-12-17 18:28:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 20:45:02 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-17 20:47:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f6f3f7994f85a7140dc29eeb9df97a7a797a410
Cr-Commit-Position: refs/heads/master@{#365876}

Powered by Google App Engine
This is Rietveld 408576698