Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1535553003: Change to X64 default build in tool scripts in sdk/bin (Closed)

Created:
5 years ago by Bill Hesse
Modified:
5 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change to X64 default build in tool scripts in sdk/bin BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/73dfc7afe0a086a6d84ce73501cdcb64fb2e7453

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M sdk/bin/dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dart.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/bin/dart2js.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/bin/dartfmt View 1 chunk +1 line, -1 line 1 comment Download
M sdk/bin/dartfmt.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/bin/pub View 1 chunk +1 line, -1 line 1 comment Download
M sdk/bin/pub.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
5 years ago (2015-12-17 12:05:54 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1535553003/diff/1/sdk/bin/dartfmt File sdk/bin/dartfmt (right): https://codereview.chromium.org/1535553003/diff/1/sdk/bin/dartfmt#newcode33 sdk/bin/dartfmt:33: DART_CONFIGURATION="ReleaseX64" Why is this not trying different configurations ...
5 years ago (2015-12-17 12:08:34 UTC) #3
Bill Hesse
5 years ago (2015-12-17 13:49:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
73dfc7afe0a086a6d84ce73501cdcb64fb2e7453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698